GraphiQL #10
Open
GraphiQL #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/pages
fix: fix errors respectively to menthors code review
feat: add library components
fix: correct build errors
feat: add validation for cyrilic
src/assets/Alex.jpg
Outdated
Collaborator
There was a problem hiding this comment.
please remake to webp format
| src="https://graphql-pokemon.js.org/introduction/javascript-examples" | ||
| className="absolute -top-12 h-full w-full" | ||
| > | ||
| Ваш браузер не поддерживает iframe! |
Collaborator
There was a problem hiding this comment.
тут мб траслэйт нужно
| src="https://graphql-pokemon.js.org/introduction/welcome" | ||
| className="absolute -top-12 h-full w-full" | ||
| > | ||
| Ваш браузер не поддерживает iframe! |
| } from "~/components/ui"; | ||
|
|
||
| const SchemaDoc = () => { | ||
| const { schema } = useAppSelector((state) => state); |
Collaborator
There was a problem hiding this comment.
wrong usage of useSelector
you need to make useSelector(state => state.schema
to only subscribe on schema state property
Collaborator
There was a problem hiding this comment.
please look through all usages of useSelector in the app and fix
| return ( | ||
| <header | ||
| className={cn( | ||
| `shadow${headerScroll}`, |
Collaborator
There was a problem hiding this comment.
tailwind classnames are not working like this. you need to have full classname in the codebase to make tailwind work and compile classname and include it in the bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
https://github.com/rolling-scopes-school/tasks/edit/master/react/modules/graphiql.md
Screenshot:
Deploy:
https://graphiql-app-git-develop-killthecreator.vercel.app
Done / deadline
25.05.2023 / 29.05.2023
Video
https://youtu.be/tfki-z8NqS0
Score: 90 / 90
Welcome route - 10 points
Sign In / Sign Up - 20 points
GraphiQL route - 50 points
General requirements - 10 points