Skip to content

fixed the order of arguments of _update_mems() function. No impact fu…#133

Open
victor-psiori wants to merge 1 commit intokimiyoung:masterfrom
victor-psiori:master
Open

fixed the order of arguments of _update_mems() function. No impact fu…#133
victor-psiori wants to merge 1 commit intokimiyoung:masterfrom
victor-psiori:master

Conversation

@victor-psiori
Copy link

Fixed the order of arguments for the _update_mems() function of MemTransformerLM class.

  • Earlier at line:
    new_mems = self._update_mems(hids, mems, mlen, qlen)
    , arguments were passed in order: hids, mems, mlen, qlen whereas class function definition expects in order: hids, mems, qlen mlen.
  • No functional impact though since qlen and mlen are added together for calculating context token length.
  • Rest of the changes caused by Black python formatter and could be ignored.

Cheers,
victor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant