Conversation
…table for showing route and stop alert lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did this as a PR so you can look at the DatabaseUtils functions I discovered working on TTime to clean up a lot of (early) code. Also wanted to point to an old query using = instead of like in the get mbta service class writing out Alerts data. Things should work better with these changes.
I'm likely to rearrange the columns for the stop and name tables so that we can get stop name and route name using the stringForQuery utility method and skipping cursor creation. We can make that change together. stringForQuery takes the familiar where clause and string array params to run the query on the db and return the value in the first column of the first row.
The logic to select alerts for a stop is complete but untested. The logic to select routes is not yet done.