Fix fuzzer finding in parse Interger literal

[kimkulling]

• closes Issue 61893 in oss-fuzz: assimp:assimp_fuzzer: Container-overflow in ODDLParser::OpenDDLParser::parseIntegerLiteral #85

Summary by CodeRabbit

• Bug Fixes

  • Fixed a rare crash when parsing numeric values at the end of input, improving stability and preventing undefined behavior.
  • Improved robustness of number parsing without changing parsing outcomes.

• Refactor

  • Minor initialization cleanup for consistency; no functional impact on users.

• Chores

  • Internal code safety improvements with no changes to public APIs.

[coderabbitai]

Walkthrough

Reorders a loop condition in parseIntegerLiteral to check bounds before dereferencing, and switches to brace initialization for a boolean in parseFloatingLiteral within code/OpenDDLParser.cpp. No public APIs changed.

Changes

Cohort / File(s)	Summary
Parser safety fix code/OpenDDLParser.cpp	Reordered while condition in OpenDDLParser::parseIntegerLiteral to check iterator against end before dereferencing; updated bool initialization in parseFloatingLiteral from parentheses to brace syntax. No signature changes.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Fix container-overflow in OpenDDLParser::parseIntegerLiteral (#85)	✅

Assessment against linked issues: Out-of-scope changes

Suggested labels

bug, fuzzer

Poem

I twitch my whiskers, scan the code—
A boundary check now guards the road.
No buffer nibble out of bounds,
The parser hops on safer grounds.
With braces snug and loops in line,
This rabbit deems the fix just fine. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 17d5783 and ea08937.

📒 Files selected for processing (1)

• code/OpenDDLParser.cpp (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

code/OpenDDLParser.cpp (2)

test/OpenDDLParserTest.cpp (18)

• in (87-87)
• in (427-427)
• in (453-453)
• in (475-475)
• in (505-505)
• in (561-561)
• in (616-616)
• end (88-88)
• end (322-322)
• end (336-336)
• end (347-347)
• end (359-359)
• end (370-370)
• end (396-396)
• end (519-519)
• end (551-551)
• end (595-595)
• end (616-616)

test/OpenDDLParserUtilsTest.cpp (5)

• end (38-38)
• end (282-282)
• end (293-293)
• end (318-318)
• end (328-328)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: PR (address)

🔇 Additional comments (2)

code/OpenDDLParser.cpp (2)

697-703: Bounds-check reordering in parseIntegerLiteral: LGTM

Short-circuiting on in != end first removes the OOB read and matches the fuzzer finding’s intent.

---

758-759: Brace initialization nit: LGTM

Style-only; no behavioral change.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kimkulling-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud