Conversation
WalkthroughThis pull request introduces a new documentation page on how to pass both static and dynamic parameters to identity providers. Additionally, it updates several social sign-in and enterprise connection guides by reordering steps, replacing “Save” with “Next,” and adding instructions for including upstream parameters during the configuration process. These changes affect documentation for Microsoft Entra ID, Apple, Bitbucket, Discord, Facebook, GitHub, GitLab, Google, LinkedIn, Microsoft, Roblox, Slack, Twitch, Twitter, and Xero. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as "Setup UI"
participant IdP as "Identity Provider"
User->>UI: Initiate social sign-in configuration
UI->>User: Display provider selection options
User->>UI: Select provider and click “Next”
UI->>User: Show Callback URL & upstream parameter entry step
User->>UI: Enter details and upstream parameters
User->>UI: Click “Save”
UI->>IdP: Submit configuration details
IdP-->>UI: Confirm configuration
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying kinde-docs-previews with
|
| Latest commit: |
dc0529c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea5914ef.kinde-docs-previews.pages.dev |
| Branch Preview URL: | https://feat-params-to-idp.kinde-docs-previews.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (19)
src/content/docs/authenticate/social-sign-in/roblox-sso.mdx (1)
24-28: Style Improvement Suggestion.
Static analysis hints recommend varying sentence openings to avoid repetitive structures. Consider rephrasing one of the successive instructions in this section for improved readability.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Roblo...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/discord.mdx (1)
20-24: Style Suggestion: Enhance Sentence Variety.
Static analysis highlights repetitive sentence beginnings in this section. Varying the phrasing slightly will improve the overall readability.🧰 Tools
🪛 LanguageTool
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Disco...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t Discord, then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/apple.mdx (1)
29-31: Style Suggestion for Callback URL Details.
Consider varying the sentence structures in the Callback URL sub-steps to avoid repetitive phrasing, as suggested by static analysis.🧰 Tools
🪛 LanguageTool
[style] ~31-~31: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/bitbucket-sso.mdx (1)
24-28: Style Suggestion: Enhance Sentence Variety.
To improve readability, consider rephrasing some of the instructions in this section to avoid starting successive sentences with the same word.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Bitbu...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Bitbucket,* then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/enterprise-connections/azure.mdx (1)
83-87: Style Suggestion: Minor Phrasing Adjustments.
Consider varying the sentence structures in these final configuration steps to prevent repetitiveness and improve overall clarity, as noted by static analysis.🧰 Tools
🪛 LanguageTool
[style] ~84-~84: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: .../auth-guides/pass-params-idp/) that you want to pass to the IdP. 13. Copy the **Callbac...(REP_WANT_TO_VB)
src/content/docs/authenticate/social-sign-in/linkedin.mdx (1)
21-21: Updated Navigation for LinkedIn Setup
Changing the action from “Save” to “Next” in the connection window helps users anticipate further steps. Consider slightly varying the sentence structure (as noted by static analysis) to avoid repetitive sentence starters.src/content/docs/authenticate/social-sign-in/facebook.mdx (1)
20-20: Navigation Improvement in Facebook Connection
Switching the prompt to “Next” (instead of “Save”) unifies the user experience across the docs. Additionally, consider rewording the introductory sentences in the Callback URL section to reduce repetitive sentence beginnings, as flagged by static analysis tools.src/content/docs/authenticate/social-sign-in/twitter.mdx (1)
31-32: Streamlined Configuration for X (formerly Twitter)
Updating the window prompt to require “Next” instead of “Save” makes it clear that further configuration steps (like entering callback URLs) are expected. Consider varying the sentence structure in this section to address style warnings from static analysis.🧰 Tools
🪛 LanguageTool
[style] ~32-~32: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select X, ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/gitlab.mdx (1)
20-21: Revised Callback URL Step for GitLab Connection
Changing the action to “Next” in the initial steps creates a more intuitive flow for setting up GitLab connections. To further improve clarity, consider rephrasing the instructions in this section to minimize repetitive sentence openings—as suggested by static analysis.🧰 Tools
🪛 LanguageTool
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **GitLa...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct GitLab, then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/slack.mdx (1)
22-24: Stylistic Suggestion: Vary Repetitive Sentence Beginnings
In the “Callback URL” section the instructions begin repeatedly with “If.” Consider rephrasing these sentences for improved readability. For example:- 1. If you use custom domains, select the **Use custom domain instead** switch. - 2. If you have only one custom domain, copy the Custom domain URL. - 3. If you have custom domains for multiple organizations, select each one from the list and copy the callbacks for each. + 1. For custom domains, toggle the **Use custom domain instead** switch. + 2. When using a single custom domain, copy the Custom domain URL. + 3. For multiple custom domains, select each one from the list and copy their respective callbacks.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/twitch.mdx (1)
26-29: Stylistic Note: Consider Varying Sentence Structure
Similar to the Slack document, the “Callback URL” instructions use consecutive sentences that start with “If.” Adjusting one or more of these can improve flow.🧰 Tools
🪛 LanguageTool
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/github.mdx (1)
20-24: Stylistic Suggestion: Reword Repetitive Constructs
Static analysis has flagged repetitive sentence openings in this section. Consider using synonyms or altering the sentence structure to avoid starting multiple sentences with the same word, particularly in the Callback URL instructions. A sample diff has been suggested in the Slack file review.🧰 Tools
🪛 LanguageTool
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **GitHu...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct GitHub, then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/google.mdx (1)
36-39: Stylistic Note: Avoid Repetitive Sentence Openings
As noted by the static analysis hint, the Callback URL instructions potentially start successive sentences with the same word. Consider rephrasing these instructions to enhance readability.🧰 Tools
🪛 LanguageTool
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct Google, then select Next. 5. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/microsoft-sso.mdx (1)
22-25: Stylistic Suggestion: Rework Repetitive Sentence Beginnings
The callback instructions still show repeated constructions (e.g., multiple “If you…” statements). Consider varying these openings to improve clarity. A similar rewording diff was suggested for Slack and GitHub documents.🧰 Tools
🪛 LanguageTool
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Microsoft, then select Next. 5. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx (5)
12-17: Improve Grammar and Terminology in Introduction
There are a couple of grammatical improvements for clarity:
- In line 12, change “The values your pass…” to “The values you pass…”.
- In line 14, change “There's a number of reason…” to “There are a number of reasons…”.
- On line 15, consider changing “sign in experience” to “sign‐in experience” for consistency.
Proposed diff:
-You can pass provider-specific parameters to an Identity Provider (IdP) during authentication. These are also known as 'upstream params'. The values your pass can either be static per connection or dynamic per user. +You can pass provider-specific parameters to an Identity Provider (IdP) during authentication. These are also known as 'upstream params'. The values you pass can either be static per connection or dynamic per user. -There's a number of reason why you might want to use upstream params: +There are a number of reasons why you might want to use upstream params: - - to create a smoother sign in experience - by passing the email through + - to create a smoother sign‐in experience by passing the email through🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...(AI_HYDRA_LEO_CP_YOUR_YOU)
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...(SIGN_UP_HYPHEN)
26-26: Fix Typo in “connecction”
There is a typographical error in line 26. Change “connecction configuration screen” to “connection configuration screen”.Proposed diff:
-Static parameters can be useful when you have specific values you always want to pass on to the IDP. These are set in the connecction configuration screen. +Static parameters can be useful when you have specific values you always want to pass on to the IDP. These are set in the connection configuration screen.
54-54: Insert Space Before Inline Code
In line 54, insert a space between “append” and the inline code snippet for better readability.Proposed diff:
-Now, when your user clicks on the Google button and Kinde creates the URL to redirect to Google, it will append`&prompt=select_account`. +Now, when your user clicks on the Google button and Kinde creates the URL to redirect to Google, it will append `&prompt=select_account`.
128-129: Correct Typo and Punctuation in Multiple Parameters Explanation
There is a typographical error (“multple” should be “multiple”) and the introductory phrase “For example” would benefit from a following comma.Proposed diff:
-You can send multple parameters this way and mix-and-match between dynamic and static in the same configuration. For example if the user entered `hello@example.com` and the following was configured: +You can send multiple parameters this way and mix-and-match between dynamic and static in the same configuration. For example, if the user entered `hello@example.com` and the following was configured:
150-150: Enhance Politeness in Feedback Request
To make the tone more polite, consider inserting “please” in line 150.Proposed diff:
-If you need other aliases added, let us know via a [feedback form](https://updates.kinde.com/). +If you need other aliases added, please let us know via a [feedback form](https://updates.kinde.com/).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx(1 hunks)src/content/docs/authenticate/enterprise-connections/azure.mdx(3 hunks)src/content/docs/authenticate/social-sign-in/apple.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/bitbucket-sso.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/discord.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/facebook.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/github.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/gitlab.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/google.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/linkedin.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/microsoft-sso.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/roblox-sso.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/slack.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/twitch.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/twitter.mdx(2 hunks)src/content/docs/authenticate/social-sign-in/xero-sso.mdx(2 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/authenticate/social-sign-in/roblox-sso.mdx
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Roblo...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/apple.mdx
[style] ~31-~31: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/linkedin.mdx
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... LinkedIn, then select Next. 5. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/xero-sso.mdx
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Xero,...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/bitbucket-sso.mdx
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Bitbu...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Bitbucket,* then select Next. 4. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/enterprise-connections/azure.mdx
[style] ~84-~84: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: .../auth-guides/pass-params-idp/) that you want to pass to the IdP. 13. Copy the **Callbac...
(REP_WANT_TO_VB)
src/content/docs/authenticate/social-sign-in/discord.mdx
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Disco...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t Discord, then select Next. 4. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/gitlab.mdx
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **GitLa...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct GitLab, then select Next. 4. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...
(AI_HYDRA_LEO_CP_YOUR_YOU)
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...
(SIGN_UP_HYPHEN)
[typographical] ~87-~87: It appears that a comma is missing.
Context: ...gin_hint=hello@example.com ``` In this case both Kinde and the IDP use the paramete...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~89-~89: Possible missing comma found.
Context: ... the same on both sides: Add this to the connection configuration: ```json { "log...
(AI_HYDRA_LEO_MISSING_COMMA)
[formatting] ~99-~99: Consider inserting a comma after an introductory phrase for better readability.
Context: ...: { alias: "login_hint" } } ``` In this case we are saying pass the login_hint par...
(IN_THAT_CASE_COMMA)
[uncategorized] ~102-~102: Possible missing comma found.
Context: ...e instead oflogin_hint` for the same value, in this case our JSON would look lik...
(AI_HYDRA_LEO_MISSING_COMMA)
[formatting] ~111-~111: Consider inserting a comma after an introductory phrase for better readability.
Context: ...e": { "alias": "login_hint" } } ``` In this case we are saying pass the username param...
(IN_THAT_CASE_COMMA)
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...rameters You can send multple parameters this way and mix-and-match between dynamic an...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~132-~132: After the expression ‘for example’ a comma is usually used.
Context: ...d static in the same configuration. For example if the user entered hello@example.com...
(COMMA_FOR_EXAMPLE)
[style] ~155-~155: This expression usually appears with a “please” in front of it.
Context: ...hint` If you need other aliases added, let us know via a [feedback form](https://updates.k...
(INSERT_PLEASE)
src/content/docs/authenticate/social-sign-in/twitter.mdx
[style] ~32-~32: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select X, ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~33-~33: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...select X, then select Next. 4. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/facebook.mdx
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/slack.mdx
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/github.mdx
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **GitHu...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct GitHub, then select Next. 4. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/google.mdx
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct Google, then select Next. 5. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/twitch.mdx
[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
src/content/docs/authenticate/social-sign-in/microsoft-sso.mdx
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Microsoft, then select Next. 5. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🔇 Additional comments (45)
src/content/docs/authenticate/social-sign-in/roblox-sso.mdx (2)
24-24: Updated Connection Selection Step.
The step now instructs users to select Next when prompted in the connection window, which aligns with the updated flow as seen in other social sign‐in guides.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Roblo...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
29-29:Details
❓ Verification inconclusive
Review Step Sequencing: Upstream Parameters.
Unlike other social sign‐in documents that now include an upstream parameters step, this file proceeds directly with “Select Save.” Please confirm whether an upstream parameters step should be added here for consistency.
Below is a shell script to verify whether the upstream parameters step is present in this file (and compare against other social sign‐in documents):
#!/bin/bash echo "Checking for 'upstream parameters' in the Roblox SSO file..." rg -n "upstream parameters" src/content/docs/authenticate/social-sign-in/roblox-sso.mdx echo "" echo "Checking for 'upstream parameters' in all social sign‐in documentation files..." for file in $(fd -e mdx '' src/content/docs/authenticate/social-sign-in/); do echo "File: $file" rg -n "upstream parameters" "$file" || echo " No upstream parameters step found in $file." echo "-----------------------------" done echo "" echo "Displaying context (lines 20-40) from roblox-sso.mdx:" sed -n '20,40p' src/content/docs/authenticate/social-sign-in/roblox-sso.mdx
Attention: Inconsistency in Step Sequencing of Social Sign‐in Documentation
It appears that the filesrc/content/docs/authenticate/social-sign-in/roblox-sso.mdxdirectly proceeds to “Select Save” (line 29) without including an upstream parameters step—as is done in other social sign‐in documents. Please confirm whether this omission is intentional or if an upstream parameters step should be added for consistency across our documentation.
- File:
src/content/docs/authenticate/social-sign-in/roblox-sso.mdx(line 29)- Observation: The expected upstream parameters step is missing.
- Suggestion: Either update the documentation to include the missing upstream parameters step or, if this deviation is intentional, add a clarifying comment to explain the departure from the standard flow.
src/content/docs/authenticate/social-sign-in/discord.mdx (4)
20-20: Updated Connection Selection for Discord.
Changing the prompt to select Next instead of a previous action correctly mirrors the updated setup flow, ensuring consistency across social sign‐in documentation.🧰 Tools
🪛 LanguageTool
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Disco...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
42-42: Addition of Upstream Parameters Step.
The new step instructing users to add any desired upstream parameters to the IdP is clear and enhances the configuration instructions.
43-43: Renumbered Subsequent Step.
Adjusting the numbering immediately after the upstream parameters step helps maintain a logical flow in the instructions.
44-44: Finalization Step Update.
The instruction to select Save as the concluding step is now clearly positioned after renumbering, which improves clarity.src/content/docs/authenticate/social-sign-in/apple.mdx (6)
27-27: Refined Apple Connection Setup Step.
The updated instruction now requires users to select Add connection, then Apple, followed by Next. This subtle change improves consistency with the new flow across the documentation set.
28-28: Clarification in Callback URL Section.
The reworded instruction for entering the Callback URL helps minimize ambiguity and enhances step clarity.
32-32: Finalize Callback URL Configuration.
Prompting users to select Save immediately after verifying their Callback URL details reinforces a clear completion of that step.
130-130: Insertion of Upstream Parameters Step.
The newly added step to incorporate upstream parameters ensures that users can pass additional configuration values to the IdP. This is a significant enhancement that brings the Apple guide in line with the broader update.
131-131: Renumbering Post Upstream Parameters.
As a direct consequence of the new upstream parameters step, renumbering subsequent steps improves clarity and maintains consistency.
132-132: Concluding Connection Setup for Apple.
Finalizing the process with a clear Save action confirms the update and ensures the guide is easy to follow.src/content/docs/authenticate/social-sign-in/bitbucket-sso.mdx (6)
24-24: Updated Bitbucket Connection Flow.
The instruction now to select Next during Bitbucket connection setup follows the new standardized process, enhancing clarity.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Bitbu...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
25-25: Clearer Callback URL Section Prompt.
Revising the instruction for the Callback URL section ensures that users receive unambiguous directions during setup.🧰 Tools
🪛 LanguageTool
[style] ~25-~25: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Bitbucket,* then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
29-29: Finalizing Callback URL Configuration.
The change to “Select Save” clearly communicates the expected action at the end of the Callback URL section.
52-52: Addition of Upstream Parameters for Bitbucket.
Including an upstream parameters step provides valuable flexibility in the configuration process, aligning this guide with other social sign‐in documents.
53-53: Consistent Step Renumbering.
Renumbering subsequent steps after adding the upstream parameters step ensures that the instructions remain logically ordered.
54-54: Concluding Credentials Setup.
Prompting users to select Save as the final step reinforces the completion of the Bitbucket configuration process.src/content/docs/authenticate/enterprise-connections/azure.mdx (4)
20-21: Introduction of Upstream Parameters Guidance.
The newly added note informs users that upstream parameters can be passed to the IdP as part of the procedure, adding clarity to the integration process.
84-84: Insertion of Upstream Parameters in Connection Configuration.
Adding the upstream parameters step in the configuration details ensures that users are aware of this capability before proceeding with the Entra ID setup.🧰 Tools
🪛 LanguageTool
[style] ~84-~84: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: .../auth-guides/pass-params-idp/) that you want to pass to the IdP. 13. Copy the **Callbac...(REP_WANT_TO_VB)
85-85: Clarification of Callback URL Step.
The revised instruction to copy the Callback URL provides unambiguous guidance for configuring the Microsoft Entra ID app.
86-86: Finalization of Connection Configuration.
Concluding the configuration process by prompting users to select Save reinforces a clear and consistent workflow.src/content/docs/authenticate/social-sign-in/xero-sso.mdx (2)
24-24: Step Flow Update for Xero Connection
Replacing the previous “Save” with “Next” in the connection window clearly indicates that additional configuration steps follow. This change helps standardize the workflow across similar social sign‑in documents.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **Xero,...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
50-52: Addition of Upstream Parameters in Xero Credentials
The new step that instructs users to “Add any [upstream params]…” enhances flexibility by allowing custom parameters to be passed to the IdP. Please verify that the linked documentation sufficiently explains upstream parameters for users who might be unfamiliar with this concept.src/content/docs/authenticate/social-sign-in/linkedin.mdx (1)
52-54: Incorporation of Upstream Parameters in LinkedIn Credentials
Introducing a step to add upstream parameters further aligns LinkedIn’s configuration process with the updates made in other social sign‑in documents. Ensure that the term “upstream params” links clearly to detailed guidance so users understand its implications.src/content/docs/authenticate/social-sign-in/facebook.mdx (1)
97-99: Enhanced Facebook Credentials Setup with Upstream Parameters
The new upstream params step in the Facebook credentials section adds valuable flexibility. Please ensure that the linked documentation clarifies what parameters can be passed and how they affect the authentication flow.src/content/docs/authenticate/social-sign-in/twitter.mdx (1)
63-65: New Upstream Parameters Step in X Credentials
Adding the upstream parameters step in the X credentials section is consistent with recent updates across other social sign‑in documents. Verify that the documentation linked for upstream parameters provides users with adequate context on their use.src/content/docs/authenticate/social-sign-in/gitlab.mdx (1)
43-45: Integration of Upstream Parameters in GitLab Credentials
The introduction of an upstream parameters step aligns GitLab’s configuration process with other social sign‑in guides. Please check that the accompanying documentation clearly explains what upstream parameters are and how they will be used during authentication.src/content/docs/authenticate/social-sign-in/slack.mdx (2)
20-20: Workflow Update: Change from “Save” to “Next” for Slack selection
The instruction now directs users to “Select Slack, then Next,” which aligns with the updated process. Please double-check that all related references in adjacent documentation remain consistent.
55-55: Addition of Upstream Parameters Step
Adding the instruction “Add any upstream params that you want to pass to the IdP” is a valuable clarification. This new step helps standardize the process across social connections.src/content/docs/authenticate/social-sign-in/twitch.mdx (2)
24-25: Workflow Update: Replace “Save” with “Next” for Twitch
Updating the step to “Select Twitch and then select Next” clearly reflects the revised flow. This should help prevent user confusion in the initial connection step.
55-57: Enhanced Clarity with Upstream Parameters and Reordered Steps
The new instructions that add upstream parameters (line 55) and then ask users to select the applications before finally pressing Save (line 57) bring better clarity and consistency with other documents.src/content/docs/authenticate/social-sign-in/github.mdx (2)
20-21: Workflow Update: GitHub Selection Now Uses “Next”
Changing the instruction to “select GitHub, then select Next” reflects the new standard process. Ensure that any downstream references also use this updated terminology.🧰 Tools
🪛 LanguageTool
[style] ~20-~20: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... section, select Add connection. 3. In the window that appears, select **GitHu...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~21-~21: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct GitHub, then select Next. 4. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
65-67: Addition of Upstream Parameters for GitHub
The inclusion of “Add any upstream params…” followed by the choice of applications reinforces consistency with other social connection guides. This is a solid improvement.src/content/docs/authenticate/social-sign-in/google.mdx (2)
35-36: Workflow Update: Google Sign in Now Uses “Next”
Updating the selection to “select Google, then select Next” is in line with the revamped workflow across the documentation. This change is clear and consistent.🧰 Tools
🪛 LanguageTool
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct Google, then select Next. 5. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
93-95: Upstream Parameters and Application Selection Steps for Google
Adding the upstream parameters step along with an explicit instruction to choose which applications should have Google sign in enabled further clarifies the configuration process.src/content/docs/authenticate/social-sign-in/microsoft-sso.mdx (2)
21-22: Workflow Update: Microsoft Sign in Instruction Refinement
Changing the instruction to “select Microsoft, then select Next” immediately clarifies the user flow. This update is consistent with changes in other social sign in guides.🧰 Tools
🪛 LanguageTool
[style] ~22-~22: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Microsoft, then select Next. 5. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
51-53: Addition of Upstream Parameters and Application Selection for Microsoft
The new step to add upstream parameters (line 51) followed by selecting the applications (line 52) and finishing with Save (line 53) properly extends the configuration process and aligns with similar updates in other guides.src/content/docs/authenticate/auth-guides/pass-params-idp.mdx (7)
1-10: YAML Front Matter Looks Good
The YAML metadata (page_id, title, sidebar, and relatedArticles) is well formatted and provides clear context for the document.
62-68: Dynamic Parameters JSON Structure is Correct
The provided JSON structure for dynamic parameters is well formatted and aligns with the explanation.
74-82: HTML Example for Auth URL is Clear
The HTML block showing the auth URL is clear and provides a useful example. No changes needed.
101-105: Remapping JSON Block is Well Formatted
The JSON block demonstrating remapping fromlogin_hinttousernameis correctly formatted.🧰 Tools
🪛 LanguageTool
[uncategorized] ~102-~102: Possible missing comma found.
Context: ...einstead oflogin_hint` for the same value, in this case our JSON would look lik...(AI_HYDRA_LEO_MISSING_COMMA)
119-123: Kinde-Provided Aliases JSON Block is Correct
The JSON example for Kinde-provided aliases is correctly formatted and clear.
131-139: Multiple Parameters JSON Example is Good
The JSON block for multiple parameters (lines 131–139) is clear and correctly formatted.🧰 Tools
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...rameters You can send multple parameters this way and mix-and-match between dynamic an...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~132-~132: After the expression ‘for example’ a comma is usually used.
Context: ...d static in the same configuration. For example if the user enteredhello@example.com...(COMMA_FOR_EXAMPLE)
140-142: Resulting URL Explanation is Clear
The explanation of the resulting URL parameters is concise and clear.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (9)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx (9)
12-12: Grammar Correction: "your pass" → "you pass".
The sentence currently reads:"The values your pass can either be static per connection or dynamic per user."
It would be clearer as:
"The values you pass can either be static per connection or dynamic per user."🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...(AI_HYDRA_LEO_CP_YOUR_YOU)
14-14: Grammar Correction: Subject-Verb Agreement.
The line:"There's a number of reason why you might want to use upstream params:"
should be updated to:
"There are a number of reasons why you might want to use upstream params:"🧰 Tools
🪛 LanguageTool
[uncategorized] ~14-~14: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ... dynamic per user. There's a number of reason why you might want to use upstream para...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
15-15: Nitpick: Consistent Hyphenation for "sign-in".
The bullet point currently uses "sign in experience". For clarity and consistency, consider changing it to "sign‐in experience".
Example diff:- - to create a smoother sign in experience - by passing the email through + - to create a smoother sign-in experience - by passing the email through🧰 Tools
🪛 LanguageTool
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...(SIGN_UP_HYPHEN)
26-26: Typo Correction: Fix "connecction".
In:"Static parameters can be useful when you have specific values you always want to pass on to the IDP. These are set in the connecction configuration screen."
Change "connecction" to "connection".
Example diff:-... set in the connecction configuration screen. +... set in the connection configuration screen.
70-70: Consistency Suggestion: Capitalize "URL".
The sentence "Thealiaskeyword tells Kinde which parameter from your auth url to use..." would be more consistent if written as "auth URL".
Example diff:-... from your auth url to use... +... from your auth URL to use...
72-72: Punctuation Suggestion: Add a Comma for Clarity.
In the sentence:"Here is an example where we provide
login_hintas part of the auth URL, where the email&login_hint=hello@example.comis included on the URL."
Consider inserting a comma after "auth URL" if it improves readability.
E.g., "…as part of the auth URL, where the email…"
83-83: Punctuation Suggestion: Insert an Introductory Comma.
The sentence:"In this case both Kinde and the IDP use the parameter name
login_hintso the configuration is the same on both sides:"
would read more clearly as:
"In this case, both Kinde and the IDP use the parameter namelogin_hint, so the configuration is the same on both sides:"
121-121: Typo and Punctuation Correction in Example Description.
The line:"You can send multple parameters this way and mix-and-match between dynamic and static in the same configuration. For example if the user entered
hello@example.comand the following was configured:"
has two issues:
- "multple" should be "multiple"
- A comma is needed after "For example"
Example diff:-For example if the user entered `hello@example.com` and the following was configured: +For example, if the user entered `hello@example.com` and the following was configured:
142-142: Style Suggestion: Politeness in Call-to-Action.
The line:"If you need other aliases added, let us know via a feedback form."
could be softened by adding "please" — for example:
"If you need other aliases added, please let us know via a feedback form."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...
(AI_HYDRA_LEO_CP_YOUR_YOU)
[uncategorized] ~14-~14: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ... dynamic per user. There's a number of reason why you might want to use upstream para...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...
(SIGN_UP_HYPHEN)
[uncategorized] ~75-~75: Possible missing comma found.
Context: ...s part of the auth URL, where the email &login_hint=hello@example.com is included on the URL. ```html https://...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~87-~87: It appears that a comma is missing.
Context: ...gin_hint=hello@example.com ``` In this case both Kinde and the IDP use the paramete...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~88-~88: Possible missing comma found.
Context: ... on both sides: Add this to the connection configuration: } } ``` In this case ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~90-~90: Loose punctuation mark.
Context: ...his to the connection configuration: } } ``` In this case we are saying pass...
(UNLIKELY_OPENING_PUNCTUATION)
[formatting] ~106-~106: Consider inserting a comma after an introductory phrase for better readability.
Context: ...e": { "alias": "login_hint" } } ``` In this case we are saying pass the username param...
(IN_THAT_CASE_COMMA)
[uncategorized] ~127-~127: Possible missing comma found.
Context: ...multple parameters this way and mix-and-match between dynamic and static in the same co...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~127-~127: After the expression ‘for example’ a comma is usually used.
Context: ...d static in the same configuration. For example if the user entered hello@example.com...
(COMMA_FOR_EXAMPLE)
[style] ~150-~150: This expression usually appears with a “please” in front of it.
Context: ...hint` If you need other aliases added, let us know via a [feedback form](https://updates.k...
(INSERT_PLEASE)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/content/docs/authenticate/social-sign-in/google.mdx (1)
37-39: Style Nitpick: Vary Bullet Point Beginnings
In the Callback URL section, the bullet points start uniformly with "If." Consider varying the sentence structure (e.g., "When using...", "Should you use...") for improved readability and style.🧰 Tools
🪛 LanguageTool
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/authenticate/social-sign-in/google.mdx(2 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/authenticate/social-sign-in/google.mdx
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct Google, then select Next. 5. In the Callback URL section: 1. If ...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🔇 Additional comments (2)
src/content/docs/authenticate/social-sign-in/google.mdx (2)
35-40: Improved Modal Navigation Flow
The update replacing Save with Next in the modal window (step 4) clearly guides users to proceed rather than prematurely saving their configuration. This change aligns with the enhanced workflow introduced in the PR. Please verify that the Next action is used consistently across all similar social sign‐in flows.🧰 Tools
🪛 LanguageTool
[style] ~36-~36: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ct Google, then select Next. 5. In the Callback URL section: 1. If ...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom domain, copy the Custom domain URL. If you have custom domains for multiple or...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
93-95: Addition of Upstream Parameters Step
The newly added step instructing users to add [upstream params] is a valuable enhancement that increases configuration flexibility. Ensure that additional context or examples are provided elsewhere (or via a link) to help users understand the implications and proper usage of these parameters.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx (8)
12-17: Grammar and Clarity CorrectionsConsider updating the introductory text for improved clarity and grammatical accuracy. For example:
- Change line 12 from “The values your pass can either be…” to “The values you pass can either be…”.
- Revise line 14 to “There are a number of reasons why you might want to use upstream params:”
- Optionally, hyphenate “sign in” to “sign-in” when used as an adjective.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...(AI_HYDRA_LEO_CP_YOUR_YOU)
[uncategorized] ~14-~14: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ... dynamic per user. There's a number of reason why you might want to use upstream para...(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...(SIGN_UP_HYPHEN)
24-28: Typo in Static Parameters DescriptionOn line 26, correct the typo by replacing “connecction” with “connection”.
44-48: Capitalization Consistency in Example HeadingConsider capitalizing “google” in the header (line 44) to “Google” for consistency with proper noun usage.
🧰 Tools
🪛 LanguageTool
[grammar] ~44-~44: “Google” is a proper noun and needs to be capitalized.
Context: ... pass upstream. ### Example: Force the google account selector to display on sign in ...(A_GOOGLE)
56-59: Spacing Issue in URL ExplanationInsert a space before the inline code on line 56 so that it reads “...it will append
&prompt=select_account.” This improves readability.
79-87: Typo in Auth URLIn line 80, “<your_kinde_sudomain>” appears to have a typo; please change it to “<your_kinde_subdomain>”.
88-97: Incomplete JSON Snippet in Connection ConfigurationThe snippet following the description on line 89 (lines 91–93) appears to only contain closing curly braces without an opening structure. Please verify whether this snippet is a continuation or if it should provide a complete JSON example for clarity.
🧰 Tools
🪛 LanguageTool
[typographical] ~89-~89: It appears that a comma is missing.
Context: ...gin_hint=hello@example.com ``` In this case both Kinde and the IDP use the paramete...(DURING_THAT_TIME_COMMA)
[uncategorized] ~90-~90: Possible missing comma found.
Context: ... on both sides: Add this to the connection configuration: } } ``` In this case ...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~92-~92: Loose punctuation mark.
Context: ...his to the connection configuration: } } ``` In this case we are saying pass...(UNLIKELY_OPENING_PUNCTUATION)
127-131: Typographical Corrections in Multiple Parameters SectionIn line 129, correct “multple” to “multiple”. Also, consider inserting a comma after “For example” (i.e. “For example, if …”) to improve readability.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~129-~129: Possible missing comma found.
Context: ...multple parameters this way and mix-and-match between dynamic and static in the same co...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~129-~129: After the expression ‘for example’ a comma is usually used.
Context: ...d static in the same configuration. For example if the user enteredhello@example.com...(COMMA_FOR_EXAMPLE)
145-153: Supported Aliases Section ReviewThe “Supported aliases” section is comprehensive. For a more inviting tone, consider adding “please” before “let us know” on line 152 (e.g., “If you need other aliases added, please let us know via a feedback form.”).
🧰 Tools
🪛 LanguageTool
[style] ~152-~152: This expression usually appears with a “please” in front of it.
Context: ...hint` If you need other aliases added, let us know via a [feedback form](https://updates.k...(INSERT_PLEASE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx
[uncategorized] ~12-~12: “your” (belonging to you) seems less likely than “you”.
Context: ... known as 'upstream params'. The values your pass can either be static per connectio...
(AI_HYDRA_LEO_CP_YOUR_YOU)
[uncategorized] ~14-~14: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ... dynamic per user. There's a number of reason why you might want to use upstream para...
(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
[uncategorized] ~15-~15: The noun “sign-in” is spelled with a hyphen.
Context: ...upstream params: - to create a smoother sign in experience - by passing the email throu...
(SIGN_UP_HYPHEN)
[grammar] ~44-~44: “Google” is a proper noun and needs to be capitalized.
Context: ... pass upstream. ### Example: Force the google account selector to display on sign in ...
(A_GOOGLE)
[typographical] ~89-~89: It appears that a comma is missing.
Context: ...gin_hint=hello@example.com ``` In this case both Kinde and the IDP use the paramete...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~90-~90: Possible missing comma found.
Context: ... on both sides: Add this to the connection configuration: } } ``` In this case ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~92-~92: Loose punctuation mark.
Context: ...his to the connection configuration: } } ``` In this case we are saying pass...
(UNLIKELY_OPENING_PUNCTUATION)
[formatting] ~108-~108: Consider inserting a comma after an introductory phrase for better readability.
Context: ...e": { "alias": "login_hint" } } ``` In this case we are saying pass the username param...
(IN_THAT_CASE_COMMA)
[uncategorized] ~129-~129: Possible missing comma found.
Context: ...multple parameters this way and mix-and-match between dynamic and static in the same co...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~129-~129: After the expression ‘for example’ a comma is usually used.
Context: ...d static in the same configuration. For example if the user entered hello@example.com...
(COMMA_FOR_EXAMPLE)
[style] ~152-~152: This expression usually appears with a “please” in front of it.
Context: ...hint` If you need other aliases added, let us know via a [feedback form](https://updates.k...
(INSERT_PLEASE)
🔇 Additional comments (16)
src/content/docs/authenticate/auth-guides/pass-params-idp.mdx (16)
1-10: Metadata Front Matter Looks GoodThe YAML header with the page ID, title, sidebar order, and related articles is correctly formatted.
18-23: Limitations Section is ClearThe “Limitations” section concisely explains the constraints (e.g. IDP-specific supported parameters, OAuth 2.0 exclusivity, etc.).
30-39: Static Parameters JSON Example is ClearThe JSON snippet demonstrating the static parameter structure is accurate and well formatted.
41-43: Clear Instructions for ReplacementsThe guidance for replacing
<param_name_to_pass>and<your_hardcoded_value>is clear and direct.
49-55: Google Account Selector JSON Example Looks CorrectThe JSON snippet provided for forcing the Google account selector is correct and easy to follow.
60-64: Dynamic Parameters Section is ClearThe introduction to dynamic parameters is well-structured and clearly explains the scenario where runtime values are needed.
66-73: Dynamic Parameters JSON Example is ValidThe JSON snippet demonstrating how to set a dynamic parameter (using the
aliaskeyword) is correctly formatted.
75-76: Alias Keyword Explanation is ClearThe explanation of the
aliaskeyword and its purpose in mapping auth URL parameters is concise and correct.
77-78: Dynamic Parameter Example is Well ExplainedThe example showcasing the use of
login_hintin the auth URL is clear and effectively demonstrates dynamic parameter usage.
99-100: Remapping Example Introduction is ClearThe explanation introducing the remapping scenario (where the IDP expects
usernameinstead oflogin_hint) is clear and sets up the following example well.
101-107: Remapping JSON Example is CorrectThe JSON snippet that demonstrates remapping (
"username": { "alias": "login_hint" }) is correctly formatted.
109-110: Clear Explanation for Remapped ParametersThe text following the snippet accurately explains how the parameter remapping will work in practice.
111-118: Kinde-Provided Aliases Section is InformativeThis section clearly explains how Kinde-provided aliases (like
login_hint) function within the authentication flow.
119-125: Alias JSON Example is Well FormattedThe JSON example showing how to set the
login_hintalias is clear and adheres to proper JSON formatting.
131-140: Multiple Parameters JSON Example is CorrectThe JSON snippet that demonstrates mixing static and dynamic parameters is well structured and clear.
142-144: Outcome Explanation for Multiple Parameters is ClearThe explanation that follows (resulting in
&prompt=login&username=hello@example.com) is succinct and clear.
2 participants
Added params step to all social connections + Entra ID OAth 2.0
Fixed a step error for creating connections
Summary by CodeRabbit