feat: client secret in header - update docs with note#678
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated two authentication docs: added a new "Client authentication method" subsection (body vs header) to the Custom OAuth 2.0 connection guide, reordered steps and troubleshooting for 401/invalid_client, and updated a cross-reference note in the Social Sign-In guide. Metadata timestamps updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying kinde-docs-preview with
|
| Latest commit: |
568a45f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8e9d638.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://tamal-feat-client-secret-in.kinde-docs-preview.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/content/docs/authenticate/social-sign-in/add-social-sign-in.mdx (1)
54-54: Use a single OAuth naming style in this sentence.Line 54 mixes “OAuth 2.0” and “OAuth2”; prefer one format for consistency.
✏️ Suggested edit
-You can also add [Custom OAuth 2.0 connections](/authenticate/custom-configurations/custom-oauth2-connection/) via the same **Social connections** area. Custom OAuth2 connections now support configuring the client authentication method (body vs. header) for the token exchange — see that guide for details. +You can also add [Custom OAuth 2.0 connections](/authenticate/custom-configurations/custom-oauth2-connection/) via the same **Social connections** area. Custom OAuth 2.0 connections now support configuring the client authentication method (body vs. header) for the token exchange — see that guide for details.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/content/docs/authenticate/social-sign-in/add-social-sign-in.mdx` at line 54, Update the sentence to use a single consistent OAuth naming style: change either "Custom OAuth 2.0 connections" or the later "OAuth2" to match (e.g., use "OAuth 2.0" in both places). Specifically edit the sentence containing "Custom OAuth 2.0 connections" and "OAuth2" so both occurrences use the same format (for example, "Custom OAuth 2.0 connections now support configuring the client authentication method (body vs. header) for the token exchange — see that guide for details.").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/content/docs/authenticate/custom-configurations/custom-oauth2-connection.mdx`:
- Line 85: In the sentence in the "Provider icons" section that reads "This icon
will appear on the sign up and sign in screens of your app," hyphenate the
compound modifiers by changing "sign up" and "sign in" to "sign-up" and
"sign-in" so they correctly modify "screens"; locate the phrase under the
Provider icons paragraph in custom-oauth2-connection.mdx and update those two
instances accordingly.
---
Nitpick comments:
In `@src/content/docs/authenticate/social-sign-in/add-social-sign-in.mdx`:
- Line 54: Update the sentence to use a single consistent OAuth naming style:
change either "Custom OAuth 2.0 connections" or the later "OAuth2" to match
(e.g., use "OAuth 2.0" in both places). Specifically edit the sentence
containing "Custom OAuth 2.0 connections" and "OAuth2" so both occurrences use
the same format (for example, "Custom OAuth 2.0 connections now support
configuring the client authentication method (body vs. header) for the token
exchange — see that guide for details.").
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/content/docs/authenticate/custom-configurations/custom-oauth2-connection.mdxsrc/content/docs/authenticate/social-sign-in/add-social-sign-in.mdx
Description (required)
Related issues & labels (optional)
Summary by CodeRabbit