Skip to content

Commit e90a62f

Browse files
committed
Wrap KindeAdminSessionBuilderTest cleanup in try/finally to prevent singleton state leaking on failure
1 parent 81b4518 commit e90a62f

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

kinde-management/src/test/java/com/kinde/KindeAdminSessionBuilderTest.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,18 @@ public static Test suite()
3636
* Rigourous Test :-)
3737
*/
3838
public void testApp() {
39-
// Initialize Guice with test modules
4039
KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.TEST);
4140
KindeGuiceSingleton.init(
4241
new KindeManagementGuiceTestModule(),
4342
new KindeTokenGuiceTestModule());
44-
45-
KindeClient kindeClient = KindeClientBuilder.builder().build();
46-
KindeAdminSession kindeAdminSession1 = KindeAdminSessionBuilder.builder().build();
47-
KindeAdminSession kindeAdminSession2 = KindeAdminSessionBuilder.builder().client(kindeClient).build();
48-
assertTrue( kindeAdminSession1 != kindeAdminSession2 );
49-
50-
// Clean up
51-
KindeGuiceSingleton.fin();
52-
KindeEnvironmentSingleton.fin();
43+
try {
44+
KindeClient kindeClient = KindeClientBuilder.builder().build();
45+
KindeAdminSession kindeAdminSession1 = KindeAdminSessionBuilder.builder().build();
46+
KindeAdminSession kindeAdminSession2 = KindeAdminSessionBuilder.builder().client(kindeClient).build();
47+
assertTrue( kindeAdminSession1 != kindeAdminSession2 );
48+
} finally {
49+
KindeGuiceSingleton.fin();
50+
KindeEnvironmentSingleton.fin();
51+
}
5352
}
5453
}

0 commit comments

Comments
 (0)