Merge pull request #217 from kinde-oss/bugfix/kindeclient-tests-bind-error

Fix OidcMetaData MissingImplementation error by removing flawed class path-based test detection

Author: Koosha-Owji

kinde-core/src/main/java/com/kinde/client/KindeClientGuiceModule.java

@@ -4,7 +4,6 @@
 import com.google.inject.Provides;
 import com.kinde.config.KindeConfig;
 import com.kinde.config.KindeConfigImpl;
-import com.kinde.config.KindeParameters;
 import com.kinde.KindeClient;
 import com.kinde.client.oidc.OidcMetaDataImpl;
 import com.kinde.guice.KindeAnnotations;
@@ -27,29 +26,10 @@ public Map<String, Object> provideParameters() {
 
     @Override
     protected void configure() {
-        // Only bind OidcMetaData if we're not in TEST mode (to avoid conflicts with test modules)
-        // Check if we're in a test environment by looking for test modules in the classpath
-        if (KindeEnvironmentSingleton.getInstance().getState() == KindeEnvironmentSingleton.State.ACTIVE && 
-            !isTestEnvironment()) {
+        if (KindeEnvironmentSingleton.getInstance().getState() == KindeEnvironmentSingleton.State.ACTIVE) {
             bind(OidcMetaData.class).to(OidcMetaDataImpl.class);
         }
         bind(KindeConfig.class).to(KindeConfigImpl.class);
         bind(KindeClient.class).to(KindeClientImpl.class);
     }
-    
-    /**
-     * Checks if we're running in a test environment.
-     * This is a simple heuristic to avoid binding conflicts with test modules.
-     * 
-     * @return true if we're in a test environment
-     */
-    private boolean isTestEnvironment() {
-        try {
-            // Check if we're running in a test context by looking for JUnit classes
-            Class.forName("org.junit.jupiter.api.Test");
-            return true;
-        } catch (ClassNotFoundException e) {
-            return false;
-        }
-    }
 }

kinde-core/src/test/java/com/kinde/session/KindeClientCodeSessionImplTest.java

@@ -1,5 +1,15 @@
 package com.kinde.session;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlPathMatching;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
 import com.github.tomakehurst.wiremock.WireMockServer;
 import com.github.tomakehurst.wiremock.client.WireMock;
 import com.kinde.KindeClient;
@@ -8,25 +18,15 @@
 import com.kinde.authorization.AuthorizationType;
 import com.kinde.authorization.AuthorizationUrl;
 import com.kinde.client.KindeCoreGuiceTestModule;
-import com.kinde.client.oidc.OidcMetaDataImplTest;
 import com.kinde.guice.KindeEnvironmentSingleton;
 import com.kinde.guice.KindeGuiceSingleton;
-import com.kinde.token.KindeTokenGuiceTestModule;
 import com.kinde.token.AccessToken;
-import com.kinde.token.KindeToken;
+import com.kinde.token.KindeTokenGuiceTestModule;
 import com.kinde.token.KindeTokens;
-import com.kinde.token.RefreshToken;
-import com.kinde.token.jwt.JwtGenerator;
 import com.kinde.token.TestKeyGenerator;
 import com.kinde.token.TestTokenGenerator;
+import com.kinde.token.jwt.JwtGenerator;
 import com.kinde.user.UserInfo;
-import org.junit.jupiter.api.*;
-
-import java.util.List;
-
-import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
-import static com.github.tomakehurst.wiremock.client.WireMock.urlPathMatching;
-import static org.junit.jupiter.api.Assertions.*;
 
 
 public class KindeClientCodeSessionImplTest {
@@ -39,7 +39,7 @@ public class KindeClientCodeSessionImplTest {
     public void setUp() {
         KindeGuiceSingleton.fin();
         KindeEnvironmentSingleton.fin();
-        KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.ACTIVE);
+        KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.TEST);
 
         // Initialize Guice with test modules
         KindeGuiceSingleton.init(

kinde-j2ee/src/test/java/com/kinde/servlet/KindeSingletonTest.java

@@ -3,6 +3,7 @@
 import com.kinde.AppTest;
 import com.kinde.client.KindeJ2eeGuiceTestModule;
 import com.kinde.token.KindeTokenGuiceTestModule;
+import com.kinde.guice.KindeEnvironmentSingleton;
 import com.kinde.guice.KindeGuiceSingleton;
 import junit.framework.Test;
 import junit.framework.TestCase;
@@ -32,12 +33,16 @@ public static Test suite()
      */
     public void testApp()
     {
-        // Initialize Guice with test modules
+        KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.TEST);
         KindeGuiceSingleton.init(
                 new KindeJ2eeGuiceTestModule(),
                 new KindeTokenGuiceTestModule());
-        
-        KindeSingleton singleton = KindeSingleton.getInstance();
-        assertTrue( true );
+        try {
+            KindeSingleton singleton = KindeSingleton.getInstance();
+            assertTrue( true );
+        } finally {
+            KindeGuiceSingleton.fin();
+            KindeEnvironmentSingleton.fin();
+        }
     }
 }

kinde-management/src/test/java/com/kinde/KindeAdminSessionBuilderTest.java

@@ -2,6 +2,7 @@
 
 import com.kinde.client.KindeManagementGuiceTestModule;
 import com.kinde.token.KindeTokenGuiceTestModule;
+import com.kinde.guice.KindeEnvironmentSingleton;
 import com.kinde.guice.KindeGuiceSingleton;
 import junit.framework.Test;
 import junit.framework.TestCase;
@@ -35,17 +36,18 @@ public static Test suite()
      * Rigourous Test :-)
      */
     public void testApp() {
-        // Initialize Guice with test modules
+        KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.TEST);
         KindeGuiceSingleton.init(
                 new KindeManagementGuiceTestModule(),
                 new KindeTokenGuiceTestModule());
-        
-        KindeClient kindeClient = KindeClientBuilder.builder().build();
-        KindeAdminSession kindeAdminSession1 = KindeAdminSessionBuilder.builder().build();
-        KindeAdminSession kindeAdminSession2 = KindeAdminSessionBuilder.builder().client(kindeClient).build();
-        assertTrue( kindeAdminSession1 != kindeAdminSession2 );
-        
-        // Clean up
-        KindeGuiceSingleton.fin();
+        try {
+            KindeClient kindeClient = KindeClientBuilder.builder().build();
+            KindeAdminSession kindeAdminSession1 = KindeAdminSessionBuilder.builder().build();
+            KindeAdminSession kindeAdminSession2 = KindeAdminSessionBuilder.builder().client(kindeClient).build();
+            assertTrue( kindeAdminSession1 != kindeAdminSession2 );
+        } finally {
+            KindeGuiceSingleton.fin();
+            KindeEnvironmentSingleton.fin();
+        }
     }
 }