Skip to content

Fix: prevent TypeError when callback state is missing; accept nullabl… #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: prevent TypeError when callback state is missing; accept nullabl… #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/KindeClientSDK.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,15 +834,15 @@ private function getProtocol()
/**
* Checks the authentication state against the provided state from the server.
*
* @param string $stateServer The state received from the server.
* @param string|null $stateServer The state received from the server, or null if missing.
*
* @throws OAuthException If the authentication state is empty or does not match the provided state.
*/
private function checkStateAuthentication(string $stateServer)
private function checkStateAuthentication(?string $stateServer)
{
$storageOAuthState = $this->storage->getState();

if (empty($storageOAuthState) || $stateServer != $storageOAuthState) {
if (empty($stateServer) || empty($storageOAuthState) || $stateServer !== $storageOAuthState) {
throw new OAuthException("Authentication failed because it tries to validate state");
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/Sdk/KindeClientSDK.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,11 @@ private function getProtocol()
return isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] === 'on' ? "https" : "http";
}

private function checkStateAuthentication(string $stateServer)
private function checkStateAuthentication(?string $stateServer)
{
$storageOAuthState = $this->storage->getState();

if (empty($storageOAuthState) || $stateServer != $storageOAuthState) {
if (empty($stateServer) || empty($storageOAuthState) || $stateServer !== $storageOAuthState) {
throw new OAuthException("Authentication failed because it tries to validate state");
}
}
Expand Down