-
Notifications
You must be signed in to change notification settings - Fork 13
fix: correct composer install command #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe README installation instructions were updated to change the composer package reference from kinde-oss/kinde-php-sdk to kinde-auth-php. No code or API modifications are included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: brettchaldecott
PR: kinde-oss/kinde-php-sdk#48
File: lib/Api/ConnectedAppsApi.php:487-487
Timestamp: 2025-05-29T12:55:46.825Z
Learning: Files in lib/Api/ and lib/Model/ directories of the kinde-php-sdk are auto-generated and should not be manually edited. Any fixes to typos or other issues in these files should be made in the source OpenAPI specification that generates the code, not in the generated PHP files themselves.
Learnt from: brettchaldecott
PR: kinde-oss/kinde-php-sdk#48
File: lib/Api/PermissionsApi.php:1393-1401
Timestamp: 2025-05-29T12:57:57.409Z
Learning: Auto-generated API client files in the Kinde PHP SDK (lib/Api/*Api.php) are generated by OpenAPI Generator and should not be manually modified. These files may contain unused helper methods that are included by the generator template, which is acceptable for auto-generated code.
📚 Learning: 2025-05-29T12:57:57.409Z
Learnt from: brettchaldecott
PR: kinde-oss/kinde-php-sdk#48
File: lib/Api/PermissionsApi.php:1393-1401
Timestamp: 2025-05-29T12:57:57.409Z
Learning: Auto-generated API client files in the Kinde PHP SDK (lib/Api/*Api.php) are generated by OpenAPI Generator and should not be manually modified. These files may contain unused helper methods that are included by the generator template, which is acceptable for auto-generated code.
Applied to files:
README.md
🔇 Additional comments (1)
README.md (1)
15-16
: Install command is correct and consistent.Verified the package name
kinde-oss/kinde-auth-php
exists on Packagist and matches Kinde’s docs. LGTM. (packagist.org, docs.kinde.com)
## Installation | ||
|
||
```bash | ||
composer require kinde-oss/kinde-php-sdk | ||
composer require kinde-oss/kinde-auth-php | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Quick scan to catch any lingering old package names.
Run to ensure no references to kinde-php-sdk
or kinde-oss/kinde-php-sdk
remain.
🏁 Script executed:
#!/bin/bash
rg -nP '(kinde-php-sdk|kinde-oss/kinde-php-sdk)'
Length of output: 927
Replace lingering references to the old kinde-php-sdk
package
Update all instances of kinde-php-sdk
or kinde-oss/kinde-php-sdk
to the new kinde-oss/kinde-auth-php
in:
- run-tests.sh
- run-examples.sh
- playground/README.md, playground/symfony/README.md, playground/codeigniter/README.md
- NAMESPACE_FIX.md
🤖 Prompt for AI Agents
In README.md around lines 12 to 17, there are lingering references to the old
package name; search for and replace all instances of "kinde-php-sdk" and
"kinde-oss/kinde-php-sdk" with "kinde-oss/kinde-auth-php" across the repository
(specifically update run-tests.sh, run-examples.sh, playground/README.md,
playground/symfony/README.md, playground/codeigniter/README.md, and
NAMESPACE_FIX.md), update any composer require lines, script invocations, and
docs to use the new package name, and confirm consistency by running the scripts
that reference the package.
Explain your changes
Fixes the README.md to have the correct install command for the package
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.