Main v2 management fastapi #57

brettchaldecott · 2025-05-13T11:01:42Z

Explain your changes

Added in FastAPI and Flask support

Checklist

I have read the “Pull requests” section in the contributing guidelines.
I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

… documentation for management

…mplementations - Standardize authentication flow between FastAPI and Flask frameworks - Correct async/sync handling in session storage implementations - Ensure consistent behavior in framework context handling - Update OAuth authentication flow to support both patterns

- Implement nest_asyncio for proper nested event loop handling - Enhance async flow in authentication process - Add flask-session and nest-asyncio to requirements.txt

- Improve session management in Flask storage implementation - Add comprehensive logging throughout the framework - Implement proper session modification tracking - Add cachelib dependency for Flask session support

- Remove redundant integration.py files in favor of framework-specific implementations - Enhance session management and user authentication flow - Add get_user_id method to framework interface - Improve logging throughout authentication process - Simplify storage manager key handling - Update FastAPI and Flask implementations to match new architecture

- Add InMemorySessionMiddleware for FastAPI session management - Update example app to use the new session middleware - Simplify session configuration in example app - Remove redundant logging statements

- Reimplement device ID based key namespacing - Restore proper handling of device-specific, global, and user-specific keys - Fix storage key isolation between different devices

- Add new test files for OAuth and UserSession edge cases - Add storage manager specific tests - Improve existing test structure and assertions - Add storage_type property to StorageManager - Update test dependencies in requirements.txt - Add pytest.ini configuration - Clean up redundant test cases

coderabbitai · 2025-05-13T11:01:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

- Upgrade requests to >=2.32.0 - Upgrade pyjwt to >=2.10.0 - Add and upgrade framework dependencies (fastapi, flask, uvicorn) - Add httpx dependency for modern HTTP client support - Organize requirements.txt into logical sections

- Include main_V2_Management_fastapi branch in CI workflow triggers - Ensure new feature branch changes are properly tested in CI pipeline

- Temporarily disable incomplete OAuth edge case tests - Comment out unfinished UserSession edge case tests - Preserve test structure for future implementation - Clean up test files for beta readiness

codecov · 2025-05-13T14:14:25Z

Codecov Report

Attention: Patch coverage is 27.84257% with 495 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
kinde_sdk/management/management_client.py	0.00%	75 Missing ⚠️
kinde_sdk/management/management_token_manager.py	0.00%	46 Missing ⚠️
kinde_sdk/core/storage/framework_aware_storage.py	20.75%	42 Missing ⚠️
kinde_sdk/auth/oauth.py	62.12%	24 Missing and 1 partial ⚠️
kinde_sdk/core/storage/storage_factory.py	51.42%	14 Missing and 3 partials ⚠️
kinde_sdk/core/framework/null_framework.py	52.38%	9 Missing and 1 partial ⚠️
kinde_sdk/core/framework/framework_factory.py	80.85%	4 Missing and 5 partials ⚠️
kinde_sdk/core/framework/framework_interface.py	70.37%	8 Missing ⚠️
kinde_sdk/core/framework/framework_context.py	76.92%	3 Missing ⚠️
kinde_sdk/management/__init__.py	0.00%	3 Missing ⚠️
... and 151 more

📢 Thoughts on this report? Let us know!

Syed Raza Abbas and others added 14 commits April 25, 2025 16:37

management module started

a92cbe1

implementation of management module without any tests

e0d6e93

usnig dynamic funcitons in management

8003e6f

moved api_client and configuration to kinde_sdk/management. Added dev…

a2a27f9

… documentation for management

added management branch to ci

0e2f4f5

feat: Add FastAPI support and improve SDK structure

b605aad

feat: Implement basic FastAPI and Flask framework support for Kinde SDK

14df0c9

fix(flask): improve async handling and add required dependencies

d34fce5

- Implement nest_asyncio for proper nested event loop handling - Enhance async flow in authentication process - Add flask-session and nest-asyncio to requirements.txt

fix(storage): enhance session handling and logging

139ab2d

- Improve session management in Flask storage implementation - Add comprehensive logging throughout the framework - Implement proper session modification tracking - Add cachelib dependency for Flask session support

feat(fastapi): add in-memory session implementation

0e3704f

- Add InMemorySessionMiddleware for FastAPI session management - Update example app to use the new session middleware - Simplify session configuration in example app - Remove redundant logging statements

fix(storage): restore device-specific key namespacing

de7109d

- Reimplement device ID based key namespacing - Restore proper handling of device-specific, global, and user-specific keys - Fix storage key isolation between different devices

Brett Chaldecott added 9 commits May 13, 2025 13:21

ci: add main_V2_Management_fastapi branch to test pipeline

24eea43

- Include main_V2_Management_fastapi branch in CI workflow triggers - Ensure new feature branch changes are properly tested in CI pipeline

fix: added missing requirement

9225047

fix: correct requirement name

0366488

test(beta): comment out incomplete test cases for beta release

fac5536

- Temporarily disable incomplete OAuth edge case tests - Comment out unfinished UserSession edge case tests - Preserve test structure for future implementation - Clean up test files for beta readiness

test: add framework initialization mocks for OAuth tests

311c8c0

fix: improve framework auto-detection by checking instance methods

6351915

feat: improve storage factory resilience with fallback mechanisms

ea4747d

test: temporarily disable unstable test cases

d186298

test: enhance login test setup with OpenID configuration mocks

2f756e3

brettchaldecott merged commit 7433bb6 into main_V2 May 13, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main v2 management fastapi #57

Main v2 management fastapi #57

Uh oh!

brettchaldecott commented May 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 13, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Main v2 management fastapi #57

Main v2 management fastapi #57

Uh oh!

Conversation

brettchaldecott commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explain your changes

Checklist

Uh oh!

coderabbitai bot commented May 13, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented May 13, 2025

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brettchaldecott commented May 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)