fix token byte issue

[KeeganBeuthin]

Fix: Restore backward compatibility for bytes tokens

Problem

Version 1.2.8 broke backward compatibility by rejecting bytes tokens in *_token methods like get_user_details_token(). Code that previously worked with bytes tokens now fails.

Fix

Modified _decode_token_if_needed_value() to automatically convert bytes to str before JWT processing:

if isinstance(token, bytes):
    try:
        token = token.decode('utf-8')
     except UnicodeDecodeError as err:
              raise KindeTokenException(f"Token {token_name} contains invalid UTF-8 bytes.") from err

[coderabbitai]

Walkthrough

The _decode_token_if_needed_value method in kinde_sdk/kinde_api_client.py was updated to properly handle token values provided as bytes. The method now decodes bytes to UTF-8 strings and raises a KindeTokenException if decoding fails, before proceeding with token verification and decoding.

Changes

File(s)	Change Summary
kinde_sdk/kinde_api_client.py	Updated _decode_token_if_needed_value to decode bytes tokens to UTF-8 and raise exception on failure; minor formatting adjustments.

Possibly related PRs

• Fix/token decode issue #54: Both PRs modify the _decode_token_if_needed_value method in kinde_sdk/kinde_api_client.py to improve token decoding logic, indicating a direct relation in addressing token processing issues.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 633f0ed and ef7475d.

📒 Files selected for processing (1)

• kinde_sdk/kinde_api_client.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• kinde_sdk/kinde_api_client.py

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55038eb and 633f0ed.

📒 Files selected for processing (1)

• kinde_sdk/kinde_api_client.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

kinde_sdk/kinde_api_client.py (1)

kinde_sdk/exceptions.py (1)

• KindeTokenException (159-160)

🪛 Ruff (0.11.9)

kinde_sdk/kinde_api_client.py

346-346: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

🔇 Additional comments (2)

kinde_sdk/kinde_api_client.py (2)

354-362: LGTM! Good formatting consistency improvements.

The formatting changes to the decode_token_params dictionary improve code readability and maintain consistency with the rest of the codebase.

---

342-347: Excellent backward compatibility fix.

The implementation correctly handles the bytes token conversion issue by:

• Detecting bytes tokens before processing
• Using UTF-8 encoding (appropriate for JWT tokens)
• Providing clear error messages for invalid UTF-8 data
• Maintaining the existing logic flow for other token types

This restores backward compatibility while maintaining proper error handling.

🧰 Tools

🪛 Ruff (0.11.9)

346-346: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)