-
Notifications
You must be signed in to change notification settings - Fork 14
Entitlements and Hard Check #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrandtKruger
wants to merge
8
commits into
kinde-oss:main
Choose a base branch
from
BrandtKruger:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
59ef2f5
Entitlements and Hard Check
BrandtKruger dff54f1
Add SPM build artifacts to .gitignore
BrandtKruger 30f8989
CodeRabbit changes
BrandtKruger 102c8d2
Update KindeSDK.xcodeproj/project.pbxproj
BrandtKruger 874f002
Fix PR comments. Add missing functionality.
BrandtKruger b75d2c6
fix coderabbit
BrandtKruger c206208
Remove Package.resolved references from Xcode project
BrandtKruger 45b6214
Remove Claims.swift and MobileEntitlements.swift references
BrandtKruger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,14 @@ | |
| 3B41B1DF2A0E5F9100EFD9E4 /* AuthStateRepository.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C12A0E5F9100EFD9E4 /* AuthStateRepository.swift */; }; | ||
| 3B41B1E02A0E5F9100EFD9E4 /* AuthError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C22A0E5F9100EFD9E4 /* AuthError.swift */; }; | ||
| 3B41B1E12A0E5F9100EFD9E4 /* DefaultLogger.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C32A0E5F9100EFD9E4 /* DefaultLogger.swift */; }; | ||
| 3B41B1E22A0E5F9100EFD9E4 /* Auth.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C42A0E5F9100EFD9E4 /* Auth.swift */; }; | ||
| 3B41B1E32A0E5F9100EFD9E4 /* Config.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */; }; | ||
| 3B41B1E22A0E5F9100EFD9E4 /* Auth.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C42A0E5F9100EFD9E4 /* Auth.swift */; | ||
| 36821D0699A84EDFBD69C26D /* Entitlement.swift */; | ||
| 3B80D15350C34728A7DE72DA /* FeatureFlag.swift */; | ||
| CFBB2F51F97B4F0FA1B6C317 /* Claims.swift */; }; | ||
| 3B41B1E32A0E5F9100EFD9E4 /* Config.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */; | ||
| C8B0314B90E44AA392AE3AC0 /* EntitlementsService.swift */; | ||
| 200A39FDEAC34E6989CFA0EF /* FeatureFlagsService.swift */; | ||
| 9C8BF9DCF8DA4FDF9858FDEE /* ClaimsService.swift */; }; | ||
| 3B41B1E42A0E5F9100EFD9E4 /* BearerTokenHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C62A0E5F9100EFD9E4 /* BearerTokenHandler.swift */; }; | ||
| 3B41B1E52A0E5F9100EFD9E4 /* BearerRequestBuilderFactory.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C72A0E5F9100EFD9E4 /* BearerRequestBuilderFactory.swift */; }; | ||
| 3B41B1E62A0E5F9100EFD9E4 /* BearerRequestBuilder.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C82A0E5F9100EFD9E4 /* BearerRequestBuilder.swift */; }; | ||
|
|
@@ -55,6 +61,20 @@ | |
| D773EAD42A897ED30049DDEE /* FlagError.swift in Sources */ = {isa = PBXBuildFile; fileRef = D773EAD32A897ED30049DDEE /* FlagError.swift */; }; | ||
| D7FD1F682A8D59E20088802F /* SDKVersion.swift in Sources */ = {isa = PBXBuildFile; fileRef = D7FD1F672A8D59E20088802F /* SDKVersion.swift */; }; | ||
| D7FD1F6E2A8D5D390088802F /* PList.swift in Sources */ = {isa = PBXBuildFile; fileRef = D7FD1F6D2A8D5D390088802F /* PList.swift */; }; | ||
| 3B41B1E22A0E5F9100EFD9E4 /* Auth.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C42A0E5F9100EFD9E4 /* Auth.swift */; | ||
| 36821D0699A84EDFBD69C26D /* Entitlement.swift */; | ||
| 3B80D15350C34728A7DE72DA /* FeatureFlag.swift */; | ||
| CFBB2F51F97B4F0FA1B6C317 /* Claims.swift */; }; | ||
| 3B41B1E32A0E5F9100EFD9E4 /* Config.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */; | ||
| C8B0314B90E44AA392AE3AC0 /* EntitlementsService.swift */; | ||
| 200A39FDEAC34E6989CFA0EF /* FeatureFlagsService.swift */; | ||
| 9C8BF9DCF8DA4FDF9858FDEE /* ClaimsService.swift */; }; | ||
| 36821D0699A84EDFBD69C26D /* Entitlement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 36821D0699A84EDFBD69C26D /* Entitlement.swift */; }; | ||
| 3B80D15350C34728A7DE72DA /* FeatureFlag.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3B80D15350C34728A7DE72DA /* FeatureFlag.swift */; }; | ||
| CFBB2F51F97B4F0FA1B6C317 /* Claims.swift in Sources */ = {isa = PBXBuildFile; fileRef = CFBB2F51F97B4F0FA1B6C317 /* Claims.swift */; }; | ||
| C8B0314B90E44AA392AE3AC0 /* EntitlementsService.swift in Sources */ = {isa = PBXBuildFile; fileRef = C8B0314B90E44AA392AE3AC0 /* EntitlementsService.swift */; }; | ||
| 200A39FDEAC34E6989CFA0EF /* FeatureFlagsService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 200A39FDEAC34E6989CFA0EF /* FeatureFlagsService.swift */; }; | ||
| 9C8BF9DCF8DA4FDF9858FDEE /* ClaimsService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9C8BF9DCF8DA4FDF9858FDEE /* ClaimsService.swift */; }; | ||
| /* End PBXBuildFile section */ | ||
|
|
||
| /* Begin PBXContainerItemProxy section */ | ||
|
|
@@ -87,7 +107,12 @@ | |
| 3B41B1C22A0E5F9100EFD9E4 /* AuthError.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AuthError.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C32A0E5F9100EFD9E4 /* DefaultLogger.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DefaultLogger.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C42A0E5F9100EFD9E4 /* Auth.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Auth.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Config.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Config.swift; sourceTree = "<group>"; }; | ||
| 36821D0799A84EDFBD69C26D /* FeatureFlag.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlag.swift; sourceTree = "<group>"; }; | ||
| 36821D0899A84EDFBD69C26D /* Claims.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Claims.swift; sourceTree = "<group>"; }; | ||
| 36821D0999A84EDFBD69C26D /* EntitlementsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EntitlementsService.swift; sourceTree = "<group>"; }; | ||
| 36821D0A99A84EDFBD69C26D /* FeatureFlagsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlagsService.swift; sourceTree = "<group>"; }; | ||
| 36821D0B99A84EDFBD69C26D /* ClaimsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ClaimsService.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C62A0E5F9100EFD9E4 /* BearerTokenHandler.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BearerTokenHandler.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C72A0E5F9100EFD9E4 /* BearerRequestBuilderFactory.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BearerRequestBuilderFactory.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C82A0E5F9100EFD9E4 /* BearerRequestBuilder.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BearerRequestBuilder.swift; sourceTree = "<group>"; }; | ||
|
|
@@ -111,6 +136,19 @@ | |
| D7FD1F672A8D59E20088802F /* SDKVersion.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SDKVersion.swift; sourceTree = "<group>"; }; | ||
| D7FD1F6C2A8D5CEC0088802F /* KindeSDK-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist; path = "KindeSDK-Info.plist"; sourceTree = "<group>"; }; | ||
| D7FD1F6D2A8D5D390088802F /* PList.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PList.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C42A0E5F9100EFD9E4 /* Auth.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Auth.swift; sourceTree = "<group>"; }; | ||
| 3B41B1C52A0E5F9100EFD9E4 /* Config.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Config.swift; sourceTree = "<group>"; }; | ||
| 36821D0799A84EDFBD69C26D /* FeatureFlag.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlag.swift; sourceTree = "<group>"; }; | ||
| 36821D0899A84EDFBD69C26D /* Claims.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Claims.swift; sourceTree = "<group>"; }; | ||
| 36821D0999A84EDFBD69C26D /* EntitlementsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EntitlementsService.swift; sourceTree = "<group>"; }; | ||
| 36821D0A99A84EDFBD69C26D /* FeatureFlagsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlagsService.swift; sourceTree = "<group>"; }; | ||
| 36821D0B99A84EDFBD69C26D /* ClaimsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ClaimsService.swift; sourceTree = "<group>"; }; | ||
| 36821D0699A84EDFBD69C26D /* Entitlement.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Entitlement.swift; sourceTree = "<group>"; }; | ||
| 3B80D15350C34728A7DE72DA /* FeatureFlag.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlag.swift; sourceTree = "<group>"; }; | ||
| CFBB2F51F97B4F0FA1B6C317 /* Claims.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Claims.swift; sourceTree = "<group>"; }; | ||
| C8B0314B90E44AA392AE3AC0 /* EntitlementsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EntitlementsService.swift; sourceTree = "<group>"; }; | ||
| 200A39FDEAC34E6989CFA0EF /* FeatureFlagsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeatureFlagsService.swift; sourceTree = "<group>"; }; | ||
| 9C8BF9DCF8DA4FDF9858FDEE /* ClaimsService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ClaimsService.swift; sourceTree = "<group>"; }; | ||
| /* End PBXFileReference section */ | ||
|
|
||
| /* Begin PBXFrameworksBuildPhase section */ | ||
|
|
@@ -123,6 +161,7 @@ | |
| 3B4B332D29F9490600D45A5A /* AppAuth in Frameworks */, | ||
| 3B4B333429F9493D00D45A5A /* Quick in Frameworks */, | ||
| 3B4B332F29F9490600D45A5A /* AppAuthCore in Frameworks */, | ||
|
|
||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
|
|
@@ -176,6 +215,7 @@ | |
| 3B41B1AF2A0E5F8500EFD9E4 /* AuthErrorSpec.swift */, | ||
| 3B41B1B02A0E5F8500EFD9E4 /* DefaultLoggerSpec.swift */, | ||
| 3B41B1B12A0E5F8500EFD9E4 /* ConfigSpec.swift */, | ||
| DACF828F6D9D444C8BE4A498 /* EntitlementsSpec.swift */, | ||
| ); | ||
| path = Tests; | ||
| sourceTree = "<group>"; | ||
|
|
@@ -441,6 +481,7 @@ | |
| 3B41B1B42A0E5F8500EFD9E4 /* AuthErrorSpec.swift in Sources */, | ||
| 3B41B1B22A0E5F8500EFD9E4 /* AuthSpec.swift in Sources */, | ||
| 3BA67F872A0A5FF600399C6A /* kinde-auth.json in Sources */, | ||
| F65CE75FFD754E5C8D36A93A /* EntitlementsSpec.swift in Sources */, | ||
| ); | ||
|
Comment on lines
457
to
464
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These should include the Please update to: files = (
+ 8D6DE2E32EE0F34000476C3F /* EntitlementsSpec.swift in Sources */,
3B41B1B32A0E5F8500EFD9E4 /* StringJWTTokenDecodeSpec.swift in Sources */,
3B41B1B52A0E5F8500EFD9E4 /* DefaultLoggerSpec.swift in Sources */,
3B41B1B62A0E5F8500EFD9E4 /* ConfigSpec.swift in Sources */,
3B41B1B42A0E5F8500EFD9E4 /* AuthErrorSpec.swift in Sources */,
3B41B1B22A0E5F8500EFD9E4 /* AuthSpec.swift in Sources */,
3BA67F872A0A5FF600399C6A /* kinde-auth.json in Sources */,
); |
||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should include the
EntitlementSpecfile.Please update to:
children = ( + 8D6DE2E22EE0F34000476C3F /* EntitlementsSpec.swift */, 3B41B1AD2A0E5F8500EFD9E4 /* AuthSpec.swift */, 3B41B1AE2A0E5F8500EFD9E4 /* StringJWTTokenDecodeSpec.swift */, 3B41B1AF2A0E5F8500EFD9E4 /* AuthErrorSpec.swift */, 3B41B1B02A0E5F8500EFD9E4 /* DefaultLoggerSpec.swift */, 3B41B1B12A0E5F8500EFD9E4 /* ConfigSpec.swift */, );