feat: add translations for durations#156
Merged
DanielRivers merged 4 commits intomainfrom Dec 17, 2025
Merged
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (32)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Member
Author
JSON Translation Sync ResultsSummary:
Modified Files:
Files with Errors: Log Output: |
davidkinde
reviewed
Dec 16, 2025
| "subscribe_button": "Předplatit a zaplatit nyní" | ||
| }, | ||
| "general": { | ||
| "translate_context": "General simple messages", |
Contributor
There was a problem hiding this comment.
Could we make the naming consistent as we have time_zero_minutes which contains the figure, but time_hours that doesn't and time_hour that does.
How about the following which allows us to also have time_hour later if we need it:
"time_one_hour": "1 hodina",
"time_hours": "hodiny",
"time_one_minute": "1 minuta",
"time_minutes": "minuty",
"time_zero_minutes": "0 minut"
Member
Author
JSON Translation Sync ResultsSummary:
Modified Files:
Files with Errors: Log Output: |
Member
Author
JSON Translation Sync ResultsSummary:
Modified Files:
Files with Errors: Log Output: |
davidkinde
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain your changes
Add translations for custom durations
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.