feat: use pwd for token instead of username#1
Merged
PranishShresth merged 2 commits intomasterfrom Aug 14, 2025
Merged
Conversation
PranishShresth
force-pushed
the
feature/verify-pwd
branch
2 times, most recently
from
f1e8712 to
c0e5aeb
Compare
PranishShresth
force-pushed
the
feature/verify-pwd
branch
4 times, most recently
from
94cc57b to
aaf51ed
Compare
PranishShresth
force-pushed
the
feature/verify-pwd
branch
from
aaf51ed to
5fe3fb1
Compare
akaur13
reviewed
Aug 14, 2025
auth-plugin/plugin_libcurl.cpp
Outdated
|
|
||
| const std::string token = username; // In a real application, you would get the token from the username or password field. | ||
| const std::string token = password; | ||
| flashmq_logf(LOG_INFO, "token: %s", token.c_str()); |
Collaborator
There was a problem hiding this comment.
printing token might not be a good idea
Collaborator
Author
There was a problem hiding this comment.
I have already removed this code :)
akaur13
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pwd for JWT verification
Cleanup