Skip to content

Conversation

GiovannaRMendes
Copy link
Contributor

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

This implementaion is a Gauss Elimination with Partial Pivoting in Python.

Screenshot

gauss_example1

Live Project Link

GiovannaRMendes/All-In-One-Python-Project

Copy link
Contributor

👋 @GiovannaRMendes 👋

We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements Gauss Elimination with Partial Pivoting in Python, introducing a new algorithm to solve linear systems via Gaussian elimination and partial pivoting. Key changes include the addition of functions for pivot selection and elimination, the implementation of back-substitution to resolve the system, and updates to the README file with usage details and screenshots.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
Gauss Elimination with Partial Pivoting/main.py New implementation of Gauss elimination with partial pivoting and matrix input handling
Gauss Elimination with Partial Pivoting/README.md Added documentation and usage examples for the algorithm
Files not reviewed (1)
  • Gauss Elimination with Partial Pivoting/runtime.txt: Language not supported
Comments suppressed due to low confidence (2)

Gauss Elimination with Partial Pivoting/main.py:5

  • To correctly select the pivot based on magnitude, consider comparing abs(matrix[index_column][index_column]) instead of matrix[index_column][index_column].
if matrix[index_column][index_column] < abs(matrix[i][index_column]):

Gauss Elimination with Partial Pivoting/main.py:36

  • [nitpick] The variable name 'sum' shadows Python's built-in function. Consider renaming it to a more descriptive name like 'total' to improve readability and avoid potential issues.
sum = 0

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! The implementation is well-structured and works as expected. Just a few minor suggestions for improvement, but overall great job.

@king04aman king04aman merged commit 5675c6d into king04aman:main Mar 27, 2025
1 check passed
Copy link
Contributor

👋 @king04aman 👋

🎉 You've just merged your pull request! We're excited to have you in our community. Keep up the fantastic contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants