-
Notifications
You must be signed in to change notification settings - Fork 129
Feat/geo distance improvements #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
15f2d8d
db19bc8
0173fc9
026b56e
0a32153
392a9e6
672129d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,23 +1,50 @@ | ||||||
from time import strftime | ||||||
from tkinter import Label, Tk | ||||||
from tkinter import Label, Tk , Button | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extra space before the comma in the import statement. Should be 'Tk, Button' instead of 'Tk , Button'.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
|
||||||
window = Tk() | ||||||
window.title("Digital Clock") | ||||||
window.geometry("300x100") | ||||||
window.configure(bg="green") | ||||||
window.resizable(False, False) | ||||||
|
||||||
use_24h = True | ||||||
|
||||||
clock_label = Label( | ||||||
window, bg="black", fg="green", font=("Arial", 30, "bold"), relief="flat" | ||||||
) | ||||||
clock_label.place(x=50, y=50) | ||||||
|
||||||
|
||||||
date_label = Label( | ||||||
window, bg="black", fg="white", font=("Arial", 14) | ||||||
) | ||||||
date_label.pack(pady=(0, 10), anchor="center") | ||||||
|
||||||
|
||||||
|
||||||
def toggle_format(_evt=None): | ||||||
global use_24h | ||||||
use_24h = not use_24h | ||||||
fmt_btn.config(text="Switch to 24-hour" if not use_24h else "Switch to 12-hour") | ||||||
|
||||||
fmt_btn = Button(window, text="Switch to 12-hour", command=toggle_format) | ||||||
fmt_btn.pack(pady=(0, 8)) | ||||||
window.bind("<f>", toggle_format) # press 'f' to toggle | ||||||
|
||||||
|
||||||
|
||||||
def update_label(): | ||||||
current_time = strftime("%H: %M: %S\n %d-%m-%Y ") | ||||||
clock_label.configure(text=current_time) | ||||||
clock_label.after(80, update_label) | ||||||
clock_label.pack(anchor="center") | ||||||
|
||||||
if use_24h: | ||||||
time_text = strftime("%H:%M:%S") | ||||||
else: | ||||||
# strip leading zero in 12h mode for a cleaner look | ||||||
time_text = strftime("%I:%M:%S %p").lstrip("0") | ||||||
clock_label.configure(text=time_text) | ||||||
date_label.configure(text=strftime("%A, %b %d, %Y")) | ||||||
window.after(1000, update_label) | ||||||
|
||||||
update_label() | ||||||
window.mainloop() | ||||||
window.mainloop() | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,32 @@ def calculate_distance_and_time(coord1, coord2, avg_speed): | |
|
||
return distance, travel_time | ||
|
||
def validate_coordinates(coord): | ||
"""Ensure latitude and longitude are within valid ranges.""" | ||
lat, lon = coord | ||
if not (-90 <= lat <= 90): | ||
raise ValueError(f"Latitude {lat} out of range (-90..90)") | ||
if not (-180 <= lon <= 180): | ||
raise ValueError(f"Longitude {lon} out of range (-180..180)") | ||
return coord | ||
|
||
def km_to_miles(km: float) -> float: | ||
"""Convert kilometers to miles.""" | ||
return km * 0.621371 | ||
|
||
def format_travel_time(hours: float) -> str: | ||
"""Format fractional hours as 'Hh Mm'.""" | ||
h = int(hours) | ||
m = int(round((hours - h) * 60)) | ||
if m == 60: | ||
h += 1 | ||
m = 0 | ||
return f"{h}h {m}m" | ||
Comment on lines
+20
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The indentation of these function definitions is inconsistent with Python standards. Function definitions should be at the top level (no indentation) or properly indented within a class. These functions appear to have 4 spaces of indentation when they should be at column 0. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
|
||
|
||
|
||
|
||
|
||
def main(): | ||
# Coordinates (latitude, longitude) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calculations create unnecessary intermediate variables and potential integer overflow. Consider calculating directly:
hours = day * 24
,minutes = day * 24 * 60
,seconds = day * 24 * 60 * 60
to avoid accumulating rounding errors and reduce memory usage.Copilot uses AI. Check for mistakes.