2 d platformer #83
Merged
2 d platformer #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @nepal143 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
king04aman
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks for your contributions, implementation of 2D Platformer game is well-structured and demonstrates effective use of classes for game entities, however here are few improvement suggestions:
- Avoid using global variables (e.g.,
player,platforms). Encapsulate them within themain()function or pass as parameters. - Simplify the jump logic by checking vertical velocity instead of relying on a jumping state.
- Refactor the Coin class to accept parameters for customization, enhancing flexibility.
|
👋 @king04aman 👋 🎉 You've just merged your pull request! We're excited to have you in our community. Keep up the fantastic contributions to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39
Developer Checklist
Summary
This PR introduces a 2D platformer game developed using Pygame. The game features player movement (left, right, and jump), a scoring system, and multiple platforms. Additionally, the Pygame version has been specified in the
requirements.txtfile to ensure consistent installations. The game has been tested with Pygame version 2.1.2, and all features are working as expected.Screenshot