Skip to content

Conversation

TejasGupta-27
Copy link

#76 RAG Implementation

Copy link
Contributor

👋 @TejasGupta-27 👋

We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon.

@TejasGupta-27
Copy link
Author

pls add labels for hacktoberfest and let me know any feedback

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, RAG project is promising and demonstrates a solid understanding of Python and relevant libraries. However, there are several areas to improve code quality:

  • Please add a .gitignore file to exclude __pycache__ and other unnecessary files from version control.
  • The README.md file requires more detailed instructions on setup and usage to enhance clarity for future users.
  • Consider implementing error handling across all modules, especially during database interactions and API calls.
  • It’s essential to validate and sanitize user inputs, especially in SQL queries, to prevent potential SQL injection risks.
  • Consider optimizing database queries and embedding storage, especially for handling larger datasets.

The project is on the right track, and with these tweaks, it can be even better.

@TejasGupta-27 TejasGupta-27 closed this by deleting the head repository Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants