forked from Lightning-AI/pytorch-lightning
-
Notifications
You must be signed in to change notification settings - Fork 1
Updated elgohr/Publish-Docker-Github-Action to a supported version (v5) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elgohr
wants to merge
43
commits into
kingmbc:master
Choose a base branch
from
elgohr-update:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed broken link in PR template. * Updated CHANGELOG.md
* add log output for slurm * change log levels * formatting Co-authored-by: Jirka Borovec <[email protected]>
* added warning to crash * formatting Co-authored-by: J. Borovec <[email protected]>
* Don't convert namedtuple to tuple * Test namedtuples sent to device correctly
* base implementation * docs + implementation * fix styling * add lr string * renaming * CHANGELOG.md * add tests * Apply suggestions from code review Co-Authored-By: Adrian Wälchli <[email protected]> * Apply suggestions from code review * Update pytorch_lightning/callbacks/lr_logger.py * Update pytorch_lightning/callbacks/lr_logger.py * add test for naming * base implementation * docs + implementation * fix styling * add lr string * renaming * CHANGELOG.md * add tests * Apply suggestions from code review Co-Authored-By: Adrian Wälchli <[email protected]> * Apply suggestions from code review * Update pytorch_lightning/callbacks/lr_logger.py * Update pytorch_lightning/callbacks/lr_logger.py * add test for naming * Update pytorch_lightning/callbacks/lr_logger.py Co-Authored-By: Adrian Wälchli <[email protected]> * suggestions from code review * fix styling * rebase * fix tests Co-authored-by: Nicki Skafte <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
* params * drop acc * acc
* move unnecessary dict trainer_options * fix tests * fix tests * formatting * missing
…ng-AI#1669) * params * drop acc * Fix Horovod distributed backend to set the root_gpu * Fixed test * Fixed tests * Fixed lint * Set root_gpu during initialization * chlog Co-authored-by: Jirka <[email protected]>
* Trigger automatic rebase on issue comment Instead of `pull_request` event (created, closed, etc.). Fixes cirrus-actions/rebase#43 * Removed workaround
* refactor default model * drop redundant seeds * formatting * path * formatting * rename
* Update docker_builds.yml * Update docker_builds.yml * nightly Co-authored-by: Jirka Borovec <[email protected]>
* fix LightningTemplateModel * update CHANGELOG.md * update LightningTemplate * update changelog * update changelog * loss fix
* change module params to dict * tiny change * reverse
* Removed unnecessary 'global_step' from wandb logger. * Fixed wrong step implementation in wandb and missing metric skipping in logger base. * simplified metric check in base logger * Added Fix Description in CHANGELOG.md * Updated wandb logger tests. * udpate test, step=3 * Moved Fix Description in CHANGELOG.md to unreleased. * Update CHANGELOG.md Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
* fix typo * Typo * typo Borda Co-authored-by: Jirka Borovec <[email protected]>
* Fine tuning example. * Fix (in train method) + Borda's comments (added argparse + fixed docstrings). * Updated CHANGELOG.md * Fix + updated docstring. * Fixes (awaelchli's comments) + docstrings. * Fix train/val loss. * Fix.
* reduce if <= num_gpus * add test with explanation * chlog * fix changelog Co-authored-by: J. Borovec <[email protected]>
* refactor trainer checks * opt * none * Apply suggestions from code review * imports * fix tensors
* refactor default model * drop redundant seeds * path * refactor loggers tests * imports
…htning-AI#1723) * update typehints * change log
* refactor default model * drop redundant seeds * drop redundant seeds * refactor models tests * refactor models tests * imports * fix conf * Apply suggestions from code review
* fix early stopping bug * allow val dataloader * update CHANGELOG.md * fix early stopping bug * allow val dataloader * update CHANGELOG.md Co-authored-by: Nicki Skafte <[email protected]>
[`parser.parse_known_args()`](https://docs.python.org/3.7/library/argparse.html#argparse.ArgumentParser.parse_known_args) actually returns a tuple of the Namespace of known args and a list of unknown args. We only want the former.
…ightning-AI#1709) * Fix Horovod backend to disable progress bar on all ranks except 0 * Add join barriers * Added changelog * Make protected and add verbosity * Refactor to disable progress bar callback in train * Removed vebose setting * Add cache check for Horovod * Test run again * Updated comment * Always skip cache for Horovod * Only reinstall when necessary * Added separate step * Fixed spacing * Skip Python 3.8
* lr * optim * wip * wip * fix mean * flake8
* refactor default model * drop redundant seeds * path * refactor callback tests * update * fix sch * wip * fix return * review
* move generated files to subfolder * remove if exists * reformat argv Co-Authored-By: Jirka Borovec <[email protected]> * update rebase * rebase yml Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: J. Borovec <[email protected]>
* add doctest to circleci * Revert "add doctest to circleci" This reverts commit c45b34e. * Revert "Revert "add doctest to circleci"" This reverts commit 41fca97. * doctest docs rst files * Revert "doctest docs rst files" This reverts commit b4a2e83. * doctest only rst * doctest debugging.rst * doctest apex * doctest callbacks * doctest early stopping * doctest for child modules * doctest experiment reporting * indentation * doctest fast training * doctest for hyperparams * doctests for lr_finder * doctests multi-gpu * more doctest * make doctest drone * fix label build error * update fast training * update invalid imports * fix problem with int device count * rebase stuff * wip * wip * wip * intro guide * add missing code block * circleci * logger import for doctest * test if doctest runs on drone * fix mnist download * also run install deps for building docs * install cmake * try sudo * hide output * try pip stuff * try to mock horovod * Tranfer -> Transfer * add torchvision to extras * revert pip stuff * mlflow file location * do not mock torch * torchvision * drone extra req. * try higher sphinx version * Revert "try higher sphinx version" This reverts commit 490ac28. * try coverage command * try coverage command * try undoc flag * newline * undo drone * report coverage * review Co-authored-by: Jirka Borovec <[email protected]> * remove torchvision from extras * skip tests only if torchvision not available * fix testoutput torchvision Co-authored-by: Jirka Borovec <[email protected]>
* refactor default model * drop redundant seeds * refactor dataloaders tests * fix multiple * fix conf * flake8 * Apply suggestions from code review Co-authored-by: William Falcon <[email protected]> Co-authored-by: William Falcon <[email protected]>
* improve pickle tests for callbacks * set mode dict as a class attr
* removed if dl from _reset_eval_dataloader() * changed to if dl != None to be more safe * hints from pep8speaks Co-authored-by: ybrovman <[email protected]>
…I#1739) * mock all packages on RTD * update
* added warning for None dataloader * fixed variable style * updated warning message * remove unused import Co-authored-by: ybrovman <[email protected]>
* update prog. bar metrics on train epoch end * changelog * wip test * more thorough testing * comments * update docs * move test Co-authored-by: Jirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elgohr/Publish-Docker-Github-Action@master is not supported anymore