Skip to content

Commit 027a4d3

Browse files
committed
add prod yaml
Signed-off-by: Mike Brown <[email protected]>
1 parent 2b064a4 commit 027a4d3

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 2535
2+
alpha:
3+
approver: "@johnbelamaric"

keps/sig-node/2535-ensure-secret-pulled-images/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,16 @@
99
- [Goals](#goals)
1010
- [Non-Goals](#non-goals)
1111
- [Proposal](#proposal)
12-
- [User Stories (Optional)](#user-stories-optional)
12+
- [User Stories](#user-stories)
1313
- [Story 1](#story-1)
1414
- [Story 2](#story-2)
1515
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
1616
- [Risks and Mitigations](#risks-and-mitigations)
1717
- [Design Details](#design-details)
1818
- [Test Plan](#test-plan)
1919
- [Graduation Criteria](#graduation-criteria)
20+
- [Alpha](#alpha)
21+
- [Deprecation](#deprecation)
2022
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
2123
- [Version Skew Strategy](#version-skew-strategy)
2224
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -27,9 +29,9 @@
2729
- [Scalability](#scalability)
2830
- [Troubleshooting](#troubleshooting)
2931
- [Implementation History](#implementation-history)
30-
- [Drawbacks](#drawbacks)
31-
- [Alternatives](#alternatives)
32-
- [Infrastructure Needed (Optional)](#infrastructure-needed-optional)
32+
- [Drawbacks [optional]](#drawbacks-optional)
33+
- [Alternatives [optional]](#alternatives-optional)
34+
- [Infrastructure Needed [optional]](#infrastructure-needed-optional)
3335
<!-- /toc -->
3436

3537
## Release Signoff Checklist
@@ -180,13 +182,11 @@ See PR (exhaustive unit tests added for alpha covering feature gate on and off f
180182

181183
### Graduation Criteria
182184

183-
184185
#### Alpha
185186

186187
- Feature implemented behind a feature flag - KubeletEnsureSecretPulledImages
187188
- Initial e2e tests completed and enabled - No additional e2e identified as yet
188189

189-
190190
#### Deprecation
191191

192192
N/A in alpha
@@ -302,7 +302,7 @@ No.
302302
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
303303

304304
Yes. When enabled, and when container images have been pulled with image pull secrets (credentials), subsequent image
305-
pulls for pods that do not contain the image pull secret that sucessfully pulled the image will have to authenticate
305+
pulls for pods that do not contain the image pull secret that successfully pulled the image will have to authenticate
306306
by trying to pull the image manifests from the registry. The image layers do not have to be re-pulled, just the
307307
manifests for authentication purposes.
308308

@@ -343,7 +343,7 @@ Why should this KEP _not_ be implemented. N/A
343343
- Make the behavior change enabled by default by changing the feature gate to true by default instead of false by default.
344344
- Discussions went back and forth on whether this should go directly to GA as a fix or alpha as a feature gate. It seems this should be the default security posture for pullIfNotPresent as it is not clear to admins/users that an image pulled by a first pod with authentication can be used by a second pod without authentication. The performance cost should be minimal as only the manifest needs to be re-authenticated. But after further review and discussion with MrunalP we'll go ahead and have a kubelet feature gate with default off for alpha in v1.22.
345345
- Set the flag at some other scope e.g. pod spec (doing it at the pod spec was rejected by SIG-Node).
346-
- For beta/ga we may revisit/replace the in memory hash map in kubelet design, with an extention to the CRI API for having the container runtime
346+
- For beta/ga we may revisit/replace the in memory hash map in kubelet design, with an extension to the CRI API for having the container runtime
347347
ensure the image instead of kubelet.
348348

349349
## Infrastructure Needed [optional]

0 commit comments

Comments
 (0)