Validate PRR approvers

Author: wojtek-t

go.mod

@@ -4,5 +4,6 @@ go 1.12
 
 require (
 	github.com/pkg/errors v0.8.1
-	gopkg.in/yaml.v2 v2.2.2
+	gopkg.in/yaml.v2 v2.2.8
+	sigs.k8s.io/yaml v1.2.0
 )

go.sum

@@ -1,6 +1,11 @@
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
+gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+sigs.k8s.io/yaml v1.2.0 h1:kr/MCeFWJWTwyaHoR9c8EjH9OumOmoF9YGiZd7lFm/Q=
+sigs.k8s.io/yaml v1.2.0/go.mod h1:yfXDCHCao9+ENCvLSE62v9VSji2MKu5jeNfTrofGhJc=

pkg/kepval/keps/validations/yaml.go

@@ -19,11 +19,14 @@ package validations
 import (
 	"bufio"
 	"fmt"
+	"io/ioutil"
 	"net/http"
 	"os"
 	"regexp"
 	"sort"
 	"strings"
+
+	"sigs.k8s.io/yaml"
 )
 
 type KeyMustBeSpecified struct {
@@ -86,7 +89,10 @@ func (m *MustHaveAtLeastOneValue) Error() string {
 	return fmt.Sprintf("%q must have at least one value", m.key)
 }
 
-var listGroups []string
+var (
+	listGroups   []string
+	prrApprovers []string
+)
 
 func init() {
 	resp, err := http.Get("https://raw.githubusercontent.com/kubernetes/community/master/sigs.yaml")
@@ -113,6 +119,34 @@ func init() {
 		os.Exit(1)
 	}
 	sort.Strings(listGroups)
+
+	resp, err = http.Get("https://raw.githubusercontent.com/kubernetes/enhancements/master/OWNERS_ALIASES")
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "unable to fetch list of aliases: %v\n", err)
+		os.Exit(1)
+	}
+	defer resp.Body.Close()
+	if resp.StatusCode != http.StatusOK {
+		fmt.Fprintf(os.Stderr, "invalid status code when fetching list of aliases: %d\n", resp.StatusCode)
+		os.Exit(1)
+	}
+
+	body, err := ioutil.ReadAll(resp.Body)
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "unable to read aliases content: %v\n", err)
+		os.Exit(1)
+	}
+	config := &struct{
+		Data map[string][]string `json:"aliases,omitempty"`
+	}{}
+	if err := yaml.Unmarshal(body, config); err != nil {
+		fmt.Fprintf(os.Stderr, "unable to read parse aliases content: %v\n", err)
+		os.Exit(1)
+	}
+	for _, approver := range config.Data["prod-readiness-approvers"] {
+		prrApprovers = append(prrApprovers, approver)
+	}
+	sort.Strings(listGroups)
 }
 
 var (
@@ -219,6 +253,24 @@ func ValidateStructure(parsed map[interface{}]interface{}) error {
 			case interface{}:
 				return &ValueMustBeListOfStrings{k, values}
 			}
+		case "prr-approvers":
+			switch values := value.(type) {
+			case []interface{}:
+				for _, value := range values {
+					v := value.(string)
+					if len(v) > 0 && v[0] == '@' {
+						// If "@" is appeneded at the beginning, remove it.
+						v = v[1:]
+					}
+
+					index := sort.SearchStrings(prrApprovers, v)
+					if index >= len(prrApprovers) || prrApprovers[index] != v {
+						return &ValueMustBeOneOf{k, v, prrApprovers}
+					}
+				}
+			case interface{}:
+				return &ValueMustBeListOfStrings{k, values}
+			}
 		}
 	}
 	return nil

pkg/kepval/keps/validations/yaml_test.go

@@ -96,6 +96,7 @@ superseded-by:
 	}
 	return buf.Bytes()
 }
+
 func TestUnmarshalSuccess(t *testing.T) {
 	yamlDoc := &proposal{
 		Title:        "test",