Skip to content

Commit 2bee05c

Browse files
authored
Merge pull request kubernetes#3206 from wojtek-t/update_kep_template
Update KEP template with comment wrt to enablement/disablement tests in PRR section
2 parents f7583a7 + 628974b commit 2bee05c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

keps/NNNN-kep-template/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,12 @@ The e2e framework does not currently support enabling or disabling feature
444444
gates. However, unit tests in each component dealing with managing data, created
445445
with and without the feature, are necessary. At the very least, think about
446446
conversion tests if API types are being modified.
447+
448+
Additionally, for features that are introducing a new API field, unit tests that
449+
are exercising the `switch` of feature gate itself (what happens if I disable a
450+
feature gate after having objects written with the new field) are also critical.
451+
You can take a look at one potential example of such test in:
452+
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
447453
-->
448454

449455
### Rollout, Upgrade and Rollback Planning

0 commit comments

Comments
 (0)