Skip to content

Commit 6f750c5

Browse files
Update questions about metrics and upgrades
1 parent 9aaec30 commit 6f750c5

File tree

1 file changed

+12
-2
lines changed
  • keps/sig-apps/2879-ready-pods-job-status

1 file changed

+12
-2
lines changed

keps/sig-apps/2879-ready-pods-job-status/README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,11 +206,21 @@ The field is only informative, it doesn't affect running workloads.
206206

207207
###### What specific metrics should inform a rollback?
208208

209-
N/A
209+
- An increase in `job_sync_duration_seconds`.
210+
- A reduction in `job_sync_num`.
210211

211212
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
212213

213-
N/A
214+
A manual test will be performed, as follows:
215+
216+
1. Create a cluster in 1.23.
217+
1. Upgrade to 1.24.
218+
1. Create long running Job A, ensure that the ready field is populated.
219+
1. Downgrade to 1.23.
220+
1. Verify that ready field in Job A is not lost, but also not updated.
221+
1. Create long running Job B, ensure that ready field is not populated.
222+
1. Upgrade to 1.24.
223+
1. Verify that Job A and B ready field is tracked again.
214224

215225
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
216226

0 commit comments

Comments
 (0)