Skip to content

Commit 90f4c9b

Browse files
nabokihmsliggitt
andcommitted
Apply suggestions from code review
Co-authored-by: Jordan Liggitt <[email protected]> Signed-off-by: m.nabokikh <[email protected]>
1 parent 4c6a711 commit 90f4c9b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -251,21 +251,20 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
251251
#### Beta
252252

253253
- Gather feedback from users
254-
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1beta1` API
254+
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1beta1` API (Beta APIs are not enabled by default, [see](https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/3136-beta-apis-off-by-default/README.md)).
255255
- Promote feature gate to Beta and make it enabled by default
256256
- Unit tests coverage improved
257-
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API
257+
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API, falls back to `authentication.k8s.io/v1alpha1` API
258258
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
259259
- Change API version
260260
- Rewrite conditions to enable the feature
261261

262262
#### GA
263263

264-
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API
264+
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API and enable by default
265265
- Promote feature gate to Stable
266266
- `kubectl alpha auth whoami` replaced with `kubectl auth whoami`
267-
- `kubectl auth whoami` command uses `authentication.k8s.io/v1` API
268-
- An article about motivation to use this feature is added to the Kubernetes blog
267+
- `kubectl auth whoami` command prefers `authentication.k8s.io/v1` API over `authentication.k8s.io/v1beta1` and `authentication.k8s.io/v1alpha1`
269268
- More integration and e2e tests cases
270269
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
271270
- Change API version

keps/sig-auth/3325-self-subject-attributes-review-api/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ reviewers:
1212
- "@mikedanese"
1313
- "@liggitt"
1414
approvers:
15-
- TBD
15+
- "@deads2k"
16+
- "@liggitt"
1617
creation-date: "2022-05-30"
1718
status: implementable
18-
stage: alpha
19+
stage: beta
1920
latest-milestone: "v1.26"
2021
milestone:
2122
alpha: "v1.26"

0 commit comments

Comments
 (0)