Skip to content

Commit caadc0f

Browse files
committed
KEP-4033: target to alpha for 1.28
Signed-off-by: Peter Hunt <[email protected]>
1 parent 0034e07 commit caadc0f

File tree

3 files changed

+21
-8
lines changed

3 files changed

+21
-8
lines changed

keps/prod-readiness/sig-node/4033.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
# "prod-readiness-approvers" group
33
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
44
kep-number: 4033
5-
beta:
5+
alpha:
66
approver: "@johnbelamaric"

keps/sig-node/4033-group-driver-detection-over-cri/README.md

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ tags, and then generate with `hack/update-toc.sh`.
9797
- [Integration tests](#integration-tests)
9898
- [e2e tests](#e2e-tests)
9999
- [Graduation Criteria](#graduation-criteria)
100+
- [Alpha](#alpha)
100101
- [Beta](#beta)
101102
- [GA](#ga)
102103
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
@@ -436,17 +437,23 @@ in back-to-back releases.
436437
- Deprecate the flag
437438
-->
438439

439-
The feature is targeting directly to beta, with the feature gate enabled by
440-
default.
440+
#### Alpha
441+
442+
- [ ] Feature implemented behind a feature flag, fallback to old behavior if flag is enabled but runtime support not present.
443+
- [ ] Initial unit tests completed and enabled
444+
441445

442446
#### Beta
443447

444448
- [ ] Feature implemented, with the feature gate enabled by default.
449+
- [ ] Released versions of CRI-O and containerd runtime implementations support the feature
450+
- [ ] Drop fallback to old behavior. CRI implementations expected to have support.
445451

446452
#### GA
447453

448-
- [ ] released versions of CRI-O and containerd runtime implementations support the feature
449454
- [ ] No bugs reported in the previous cycle.
455+
- [ ] Remove fallback behavior
456+
- [ ] Remove feature gate
450457

451458
### Upgrade / Downgrade Strategy
452459

@@ -462,6 +469,11 @@ enhancement:
462469
cluster required to make on upgrade, in order to make use of the enhancement?
463470
-->
464471

472+
The fallback behavior specified in alpha will prevent the majority of regressions, as Kubelet will choose a cgroup driver,
473+
same as it used to before this KEP, even when the feature gate is on.
474+
475+
The feature gate is another layer of protection, requiring admins to specifically opt-into this behavior.
476+
465477
### Version Skew Strategy
466478

467479
<!--
@@ -544,7 +556,7 @@ automations, so be extremely careful here.
544556
Yes. If/when the runtime is updated to a version that supports this, kubelet
545557
will ignore the cgroupDriver config option/flag. However, this change in
546558
behavior should not cause any breakages (on the contrary, it should fix
547-
scenarios where the kubelet `--cgorup-driver` setting is incorrectly
559+
scenarios where the kubelet `--cgroup-driver` setting is incorrectly
548560
configured). With old versions of the container runtimes (that don't support
549561
the new field in the CRI API) the default behavior is not changed.
550562

keps/sig-node/4033-group-driver-detection-over-cri/kep.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ see-also: []
1717
replaces: []
1818

1919
# The target maturity stage in the current dev cycle for this KEP.
20-
stage: beta
20+
stage: alpha
2121

2222
# The most recent milestone for which work toward delivery of this KEP has been
2323
# done. This can be the current (upcoming) milestone, if it is being actively
@@ -26,8 +26,9 @@ latest-milestone: "v1.28"
2626

2727
# The milestone at which this feature was, or is targeted to be, at each stage.
2828
milestone:
29-
beta: "v1.28"
30-
stable: "v1.yy"
29+
alpha: "v1.28"
30+
beta: "v1.yy"
31+
stable: "v1.zz"
3132

3233
# The following PRR answers are required at alpha release
3334
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)