Skip to content

Commit dfb5b64

Browse files
authored
Merge pull request kubernetes#3753 from logicalhan/slis
KEP-3466: update beta graduation requirements for component SLIs
2 parents 92cda6f + c41c17e commit dfb5b64

File tree

2 files changed

+16
-12
lines changed
  • keps
    • prod-readiness/sig-instrumentation
    • sig-instrumentation/3466-kubernetes-component-health-slis

2 files changed

+16
-12
lines changed

keps/prod-readiness/sig-instrumentation/3466.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@
44
kep-number: 3466
55
alpha:
66
approver: "@wojtek-t"
7+
beta:
8+
approver: "@wojtek-t"

keps/sig-instrumentation/3466-kubernetes-component-health-slis/README.md

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -128,20 +128,20 @@ checklist items _must_ be updated for the enhancement to be released.
128128

129129
Items marked with (R) are required *prior to targeting to a milestone / release*.
130130

131-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
132-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
133-
- [ ] (R) Design details are appropriately documented
134-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
135-
- [ ] e2e Tests for all Beta API Operations (endpoints)
136-
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
137-
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
131+
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
132+
- [X] (R) KEP approvers have approved the KEP status as `implementable`
133+
- [X] (R) Design details are appropriately documented
134+
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
135+
- [X] e2e Tests for all Beta API Operations (endpoints)
136+
- [X] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
137+
- [X] (R) Minimum Two Week Window for GA e2e tests to prove flake free
138138
- [ ] (R) Graduation criteria is in place
139139
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
140-
- [ ] (R) Production readiness review completed
140+
- [X] (R) Production readiness review completed
141141
- [ ] (R) Production readiness review approved
142-
- [ ] "Implementation History" section is up-to-date for milestone
143-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
144-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
142+
- [X] "Implementation History" section is up-to-date for milestone
143+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
144+
- [X] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
145145

146146
<!--
147147
**Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
@@ -336,7 +336,6 @@ We will target this feature behind a flag `ComponentSLIs`
336336

337337
###### How can this feature be enabled / disabled in a live cluster?
338338

339-
340339
- [ ] Feature gate (also fill in values in `kep.yaml`)
341340
- Feature gate name: `ComponentSLIs`
342341
- Components depending on the feature gate:
@@ -346,6 +345,9 @@ We will target this feature behind a flag `ComponentSLIs`
346345
+ controller-manager
347346
+ kube-proxy
348347

348+
###### Are there any tests for feature enablement/disablement?
349+
350+
Given this feature is purely in-memory, no enablement/disablement tests are needed.
349351

350352
###### Does enabling the feature change any default behavior?
351353

0 commit comments

Comments
 (0)