Skip to content

Commit ebcd8cf

Browse files
Add details of upgrade->downgrade->upgrade manual test
1 parent b8309a5 commit ebcd8cf

File tree

1 file changed

+18
-4
lines changed
  • keps/sig-apps/2307-job-tracking-without-lingering-pods

1 file changed

+18
-4
lines changed

keps/sig-apps/2307-job-tracking-without-lingering-pods/README.md

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -451,11 +451,24 @@ No implications to node runtime.
451451

452452
#### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
453453

454-
Integration tests cover feature gate disablement and re-enablement.
454+
Integration tests cover feature gate disablement and re-enablement.
455455

456-
A manual upgrade->downgrade->upgrade flow will be executed prior to Beta
457-
graduation to ensure that a running Job falls back to tracking without
458-
finalizers. The KEP will be updated with the findings of the test.
456+
The following upgrade->downgrade->upgrade flow was executed on GKE:
457+
458+
1. Start at version 1.22.2
459+
1. Create a Job A that sleeps for 1 minute, with high completions number and low parallelism.
460+
1. Verify that the Job A is running and pods don’t have finalizers
461+
1. Upgrade to 1.23 with JobTrackingWithFinalizers feature enabled
462+
1. Verify that Job A still runs and still creates pods without finalizers.
463+
1. Create a Job B with similar characteristics as Job A.
464+
1. Verify that the Job B is running and pods have finalizers while running.
465+
1. Downgrade to 1.22.2
466+
1. Verify that ob B still runs and creates pods without finalizers
467+
1. Upgrade to 1.23 with JobTrackingWithFinalizers feature enabled again.
468+
1. Verify that Job B still runs and still create pods without finalizers.
469+
1. Create a Job C and verify that pods have finalizers while running.
470+
471+
The flow was completed successfully with all the stated verifications.
459472

460473
#### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
461474

@@ -593,6 +606,7 @@ No implications to node runtime.
593606
- 2021-04-20: Target 1.22 for Alpha.
594607
- 2021-07-09: Alpha implementation merged
595608
- 2021-08-18: PRR completed and graduation to beta proposed.
609+
- 2021-10-14: Added details for Upgrade->Downgrade->Upgrade manual test.
596610

597611
## Drawbacks
598612

0 commit comments

Comments
 (0)