Honor common_headers if specified from JS module#36
Open
matmar10 wants to merge 1 commit intokiranz:masterfrom
Open
Honor common_headers if specified from JS module#36matmar10 wants to merge 1 commit intokiranz:masterfrom
matmar10 wants to merge 1 commit intokiranz:masterfrom
Conversation
Contributor
Author
|
Bump. Can we get this merged? |
kiranz
reviewed
Jun 9, 2021
| this.port = configuration.port; | ||
| this.base_path = configuration.base_path || ''; | ||
| this.read_timeout = configuration.read_timeout || 60000; | ||
| suiteConfigData.common_headers = configuration.common_headers || []; |
Owner
There was a problem hiding this comment.
common_headers coming from js module should go to this.commonHeaders object, see line# 268 in master branch
| base_path: suiteConfigData.base_path, | ||
| read_timeout: suiteConfigData.read_timeout | ||
| read_timeout: suiteConfigData.read_timeout, | ||
| common_headers: suiteConfigData.common_headers, |
Owner
There was a problem hiding this comment.
This is not required, because we are already reading common_headers from YAML on line#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.