Skip to content

Migrate public DICOM notebooks from NBIA to IDC#37

Open
kirbyju wants to merge 3 commits intomainfrom
migrate-to-idc-dicom-12318540016014198590
Open

Migrate public DICOM notebooks from NBIA to IDC#37
kirbyju wants to merge 3 commits intomainfrom
migrate-to-idc-dicom-12318540016014198590

Conversation

@kirbyju
Copy link
Owner

@kirbyju kirbyju commented Feb 26, 2026

Migrated seven notebooks from using NBIA/tcia_utils to NCI Imaging Data Commons (IDC) using idc-index. Replaced shared carts with hardcoded UIDs and updated restricted access status.


PR created automatically by Jules for task 12318540016014198590 started by @kirbyju

This commit updates seven notebooks to reflect the transition from using
NBIA to NCI Imaging Data Commons (IDC) for accessing public DICOM data.

Changes included:
- Replaced `tcia_utils` with `idc-index` for querying and downloading.
- Replaced `nbia.getSharedCart()` calls with hardcoded SeriesInstanceUID lists.
- Updated reporting logic to use pandas on `idc_client.index`.
- Added notes regarding restricted collections moving to NCI General Commons.
- Implemented `seg_index` queries to find referenced image series.

Affected notebooks:
1. TCIA_Series_UID_Report.ipynb
2. CPTAC/CPTAC.ipynb
3. TCGA/TCGA_Clinical.ipynb
4. TCIA_Segmentations.ipynb
5. TCIA_Image_Visualization_with_itkWidgets.ipynb
6. TCIA_RTStruct_SEG_Visualization_with_itkWidgets.ipynb
7. TCIA_STL_Visualization_with_itkWidgets.ipynb

Co-authored-by: kirbyju <2379527+kirbyju@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

google-labs-jules bot and others added 2 commits February 26, 2026 13:29
Updated seven notebooks to transition from NBIA to IDC.
Refined the note for restricted collections to reflect they have moved
to the Cancer Research Data Commons with different access mechanisms.
Replaced shared carts with hardcoded UID lists and used idc-index
for DICOM data access.

Co-authored-by: kirbyju <2379527+kirbyju@users.noreply.github.com>
…iewer

This commit refines the migration of seven notebooks to IDC by:
- Using `seg_index` to lookup `segmented_SeriesInstanceUID` for pairing
  images with segmentations (RTSTRUCT/SEG).
- Replacing all occurrences of `simpleDicomViewer` with the IDC OHIF
  viewer embedded via `IFrame`.
- Updating examples to use `SEG` modality where `seg_index` lookup is
  demonstrated.
- Ensuring restricted access notes use the refined wording about Cancer
  Research Data Commons.
- Using pandas operations on `idc_client.index` for reporting.

Affected notebooks:
1. TCIA_Series_UID_Report.ipynb
2. CPTAC/CPTAC.ipynb
3. TCGA/TCGA_Clinical.ipynb
4. TCIA_Segmentations.ipynb
5. TCIA_Image_Visualization_with_itkWidgets.ipynb
6. TCIA_RTStruct_SEG_Visualization_with_itkWidgets.ipynb
7. TCIA_STL_Visualization_with_itkWidgets.ipynb

Co-authored-by: kirbyju <2379527+kirbyju@users.noreply.github.com>
@@ -21,7 +21,7 @@
"source": [
Copy link
Owner Author

@kirbyju kirbyju Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention this in the summary instead of its own section. "Restricted access have moved to the Cancer Research Data Commons and have different access mechanisms than the ones described in this notebook. Please see https://www.cancerimagingarchive.net/nih-controlled-data-access-policy/ for more details."


Reply via ReviewNB

@@ -21,7 +21,7 @@
"source": [
Copy link
Owner Author

@kirbyju kirbyju Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not apply this change.


Reply via ReviewNB

@@ -21,7 +21,7 @@
"source": [
Copy link
Owner Author

@kirbyju kirbyju Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download an example manifest from TCIA instead of just using two series UIDs. https://www.cancerimagingarchive.net/wp-content/uploads/EAY131-DA-RAD_v01_20260216.tcia is a good one. This nbia.manifestToList() function is just removing the first 6 lines of header information and then the rest of the tcia file will be one Series Instance UID per line.


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant