Fix laravel 12 compatibility#132
Open
sanduestefan wants to merge 2 commits intokirschbaum-development:masterfrom
Open
Fix laravel 12 compatibility#132sanduestefan wants to merge 2 commits intokirschbaum-development:masterfrom
sanduestefan wants to merge 2 commits intokirschbaum-development:masterfrom
Conversation
- Extract underlying session store from SymfonySessionDecorator using reflection - Prevents TypeError when setLaravelSession expects Session interface but receives decorator - Maintains backward compatibility with older Laravel versions
- Remove array type hint from fill() method to match parent class signature - Add runtime type checking for backward compatibility - Prevents Fatal Error: Declaration must be compatible with Illuminate\Support\Fluent::fill()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Laravel 12 Compatibility Issues
This PR resolves two critical compatibility issues preventing the package from working with Laravel 12.
Issues Fixed
1. SymfonySessionDecorator TypeError
TypeError: Argument #1 ($store) must be of type Illuminate\Contracts\Session\Session, Illuminate\Session\SymfonySessionDecorator givensrc/NovaInlineRelationshipRequest.php2. Fluent Method Signature Incompatibility
Fatal error: Declaration must be compatible with Illuminate\Support\Fluent::fill($attributes)src/Helpers/Fluent.phpTesting
✅ Tested with Laravel 12.28.1 and Nova 4.0
✅ Inline relationship functionality works as expected
✅ Maintains backward compatibility with older Laravel versions
Impact
Allows the package to work seamlessly with Laravel 12 while preserving all existing functionality.