Fix SPM warning for Xcode 12 and 13#193
Open
DenTelezhkin wants to merge 1 commit intokishikawakatsumi:masterfrom
Open
Fix SPM warning for Xcode 12 and 13#193DenTelezhkin wants to merge 1 commit intokishikawakatsumi:masterfrom
DenTelezhkin wants to merge 1 commit intokishikawakatsumi:masterfrom
Conversation
Unlike CocoaPods, SPM platforms only specify minimum supported deployment targets, and it's recommended to only specify platforms, if minimum supported deployment target is **higher** than Xcode's, which is not the case here. When using package on Xcode 13, SPM shows a warning: `.../UICKeyChainStore/Package.swift The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99.` By removing platforms from Package.swift this warning will go away, since now Xcode is in charge of what platforms are supported, and automatically sets minimum deployment target for this package (which, on Xcode 13, is iOS 9). This does not drop support for iOS 8, as support for iOS 8 was already dropped by Xcode 12, this change only removes a warning. This PR is an alternative to kishikawakatsumi#188, so you can have a choice in two different approaches. This one seems better to me, as you no longer need to manage deployment versions, and Xcode can just select whatever is supported at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike CocoaPods, SPM platforms only specify minimum supported deployment targets, and it's recommended to only specify platforms, if minimum supported deployment target is higher than Xcode's, which is not the case here.
When using package on Xcode 13, SPM shows a warning:
.../UICKeyChainStore/Package.swift The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99.By removing platforms from Package.swift this warning will go away, since now Xcode is in charge of what platforms are supported, and automatically sets minimum deployment target for this package (which, on Xcode 13, is iOS 9).
This does not drop support for iOS 8, as support for iOS 8 was already dropped by Xcode 12, this change only removes a warning.
This PR is an alternative to #188, so you can have a choice in two different approaches. This one seems better to me, as you no longer need to manage deployment versions, and Xcode can just select whatever is supported at the moment.