Update to golang.org/x/tools v0.30.0 for go1.24 #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanharris
force-pushed
the
duncan/update-tools-go1.24
branch
2 times, most recently
from
0b927ef to
756d40d
Compare
duncanharris
force-pushed
the
duncan/update-tools-go1.24
branch
from
756d40d to
d236e7d
Compare
kurtmc
approved these changes
Feb 12, 2025
Collaborator
|
@duncanharris Do you mind updating test matrix in CI config to remove obsoleted versions as well? |
Contributor
Author
Done |
kisielk
previously approved these changes
Feb 16, 2025
kisielk
approved these changes
Feb 17, 2025
Contributor
Author
|
Thanks @kisielk. I think we now need a new release so we can continue to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go1.24 and errcheck v1.8.0 get errors like:
internal error: package "math" without types was imported from ...Updated
golang.org/x/toolsto latest and now works fine with go1.24Minimum Go version now 1.22 because that is required by the updated
golang.org/x/tools