Skip to content

Deprecate ErrNoGoFiles as it's never returned #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtcaciuc merged 2 commits into from
Feb 19, 2025
Merged

Deprecate ErrNoGoFiles as it's never returned #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2ee23
Deprecate ErrNoGoFiles as it's never returned
alexandear Feb 17, 2025
0fe9f58
Merge branch 'master' into deprecate-err-no-go-files
dtcaciuc Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion errcheck/errcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ func init() {
}

var (
// ErrNoGoFiles is returned when CheckPackage is run on a package with no Go source files
// ErrNoGoFiles is returned when CheckPackage is run on a package with no Go source files.
//
// Deprecated: this error is no longer returned by errcheck.LoadPackages.
ErrNoGoFiles = errors.New("package contains no go source files")
)

Expand Down
4 changes: 0 additions & 4 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ func mainCmd(args []string) int {

result, err := checkPaths(&checker, paths...)
if err != nil {
if err == errcheck.ErrNoGoFiles {
fmt.Fprintln(os.Stderr, err)
return exitCodeOk
}
fmt.Fprintf(os.Stderr, "error: failed to check packages: %s\n", err)
return exitFatalError
}
Expand Down