Open
Conversation
Use HTTPS in comments and codew where possible Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Owner
|
While I can see the value in this, it looks like all of these are third-party compile-time libraries kismet integrates (nlohmann json, mpack, etc) - in general i prefer to leave those headers as untouched as possible, because it makes integration of future versions a lot simpler. It might be worth submitting to them directly to change their URLs though, because they're used by thousands of other projects, too! I'm not opposed to changing headers that are from kismet itself, of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HTTPS in comments and codew where possible
This is a smaller version of #555
Note: The apple KB links are dead / were already dead and need to be updated to a modern equiv