Development branch for v3.0.0 #264

Pfeil · 2025-01-24T15:29:06Z

Current changes:

validation speedup
type API and EOSC DTR support
ARM support in future releases

Breaking changes:

Due to the validation rewrite, validation errors may occur in different order. While we never gave a guarantee on this, it may be unexpected. Now, there is explicitly no defined order due to parallel/async code execution.
A profile is not required anymore in order to support records following profiles in the EOSC DTR, which do not require this. In such a case, only attribute validation is being performed (as always). Before, we expected at least one profile within the record.
If a profile does not explicitly state otherwise, additional attributes (that are not defined in a profile) are allowed in a record. Their values will also be validated (attribute validation).

# Conflicts: # build.gradle

…mas and structure

- support for records without profiles - support for records with multiple profiles - support for multiple profile attribute keys/types - support for additional attributes - in general, attribute validation and profile validation are now separate tasks

…on class

…tors per attribute.

…experiments # Conflicts: # build.gradle

…em for validation

…experiments # Conflicts: # build.gradle # src/main/java/edu/kit/datamanager/pit/web/impl/TypingRESTResourceImpl.java

…current state of the APIs

…validation error to the user, not as a PidNotFoundError.

…l attributes, now default to true.

…cal pid system

The type-api was fixed and in addition, the dtr-test instance has an ill-formed schema which is not accepted by our new validation library. Therefore, this test does not make sense anymore as anything else is covered by the other tests.

This reverts commit bc39406.

New schema validator

coderabbitai · 2025-06-12T13:35:55Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dev-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…f Batch Record creation endpoint + tests Signed-off-by: Maximilian Inckmann <[email protected]>

Signed-off-by: Maximilian Inckmann <[email protected]>

# Conflicts: # build.gradle

API for creating interconnected FAIR-DOs (a FAIR-DO graph) in a single request

# Conflicts: # build.gradle # config/application-default.properties # gradle.properties

…Ds, including the prefix. Fixes #325 Before, we returned a map "placeholder -> suffix". Now we return properly "placeholder -> full_PID"

Pfeil · 2025-09-30T10:10:52Z

This last commit fixes #325

Pfeil and others added 30 commits August 29, 2024 14:53

speedup: use fast, async cache

efb4bf5

speedup: use default work stealing executor for "async" cache

160bfe0

speedup: use extra executors for validation and deserialization

f976bdd

Merge branch 'master' into validation-speedup-experiments

0d8ce40

# Conflicts: # build.gradle

chore: rename TypeRegistry to DtrTest, as it depends on dtr-test sche…

c7e6cbb

…mas and structure

feat: add main code base for type-api support

439e8b0

feat: more flexible validation

5ee3e4a

- support for records without profiles - support for records with multiple profiles - support for multiple profile attribute keys/types - support for additional attributes - in general, attribute validation and profile validation are now separate tasks

feat: use virtual threads for async execution

dabaa4d

cleanup: remove unused methods which depended on the old TypeDefiniti…

3ff56e4

…on class

fix: assumed wrong type of baseUrl

91538cb

chore: cleanup, formatting, typos

df87d27

feat: introduce SchemaSetGenerator to support different schema genera…

a04dc32

…tors per attribute.

Merge remote-tracking branch 'origin/master' into validation-speedup-…

9b89c01

…experiments # Conflicts: # build.gradle

added bulk create feature

2221af1

added more information

b9d0da4

feat: read additionalAttributes allowed from profiles and consider th…

0695cc6

…em for validation

fix: throw error on PID not found

8544909

fix: missing slash after type api endpoint

7938072

fix(tests): check assumptions in etag test setup

85db2a0

Merge remote-tracking branch 'origin/master' into validation-speedup-…

19b030a

…experiments # Conflicts: # build.gradle # src/main/java/edu/kit/datamanager/pit/web/impl/TypingRESTResourceImpl.java

fix(tests): type api test for complex type now properly reflects the …

e7361f4

…current state of the APIs

test: some general profile attributes with type API

18a06ba

cleanup: remove unused domain classes

69b0d57

fix: apply json schema validation correctly

aaba94d

fix: a attribute which is not registered, shall being presented as a …

c4d1aa2

…validation error to the user, not as a PidNotFoundError.

cleanup: apply linter suggestions

24c5beb

fix(tests): profiles which do not specify their handling of additiona…

186e4a8

…l attributes, now default to true.

fix(tests): sanity check about the number of tests to execute with lo…

e61ba54

…cal pid system

cleanup: apply linter suggestions

4fd4543

docs: add note about why this test currently fails

04bff17

Pfeil added 16 commits June 11, 2025 10:43

Merge branch 'dev-v3' into 109-multipleFAIR_DOs

315379d

fix: correct message formatting in ExternalServiceException

22011d4

fix: filter out schemas with errors, as they may accept anything

45646df

feat: add logging for validation errors and exceptions in AttributeInfo

1930938

feat: add logging for schema retrieval errors in SchemaSetGenerator

262c25a

Merge branch 'dev-v3' into 262-new-schema-validator

efdb386

fix(test): update checksum validation examples to new validator

bc39406

fix: attribute value parsing and corresponding tests

4484db7

fix: schema presence check used isEmpty, meant isNull

2eade02

fix: improve logging message for schema retrieval errors

97cb372

Revert "fix(test): update checksum validation examples to new validator"

7d55112

This reverts commit bc39406.

fix: enhance schema validation logging and null checks

4f4bf89

deps: update json-schema-validator dependency to version 1.5.7

7aa7a0f

fix: update schema validation logic and improve error handling

f3d25c3

Merge pull request #272 from kit-data-manager/262-new-schema-validator

857d912

New schema validator

Pfeil mentioned this pull request Jun 12, 2025

JSON Schema Validator dependency is in maintenance mode. Consider alternatives. #262

Closed

maximiliani and others added 6 commits July 15, 2025 17:09

added mapping from user-provided PIDs to real Handle PIDs to result o…

74b9428

…f Batch Record creation endpoint + tests Signed-off-by: Maximilian Inckmann <[email protected]>

Improved JavaDoc

4e168d7

Signed-off-by: Maximilian Inckmann <[email protected]>

minor fixes

b66c146

Signed-off-by: Maximilian Inckmann <[email protected]>

minor fixes to the Swagger API docs

d1e0782

Signed-off-by: Maximilian Inckmann <[email protected]>

minor style fixes

1d481c4

Signed-off-by: Maximilian Inckmann <[email protected]>

Merge remote-tracking branch 'origin/dev-v3' into 109-multipleFAIR_DOs

8b2ae49

# Conflicts: # build.gradle

Pfeil mentioned this pull request Jul 17, 2025

Code generation should store which records exist already to enable record updates later kit-data-manager/fair-do-designer#39

Closed

Pfeil and others added 4 commits July 17, 2025 13:31

Merge pull request #247 from maximiliani/109-multipleFAIR_DOs

fd4478c

API for creating interconnected FAIR-DOs (a FAIR-DO graph) in a single request

Merge branch 'development' into dev-v3

260c66d

# Conflicts: # build.gradle # config/application-default.properties # gradle.properties

Merge branch 'master' into dev-v3

0f68003

fix: API for creating multiple PIDs returns mappings now with full PI…

269776c

…Ds, including the prefix. Fixes #325 Before, we returned a map "placeholder -> suffix". Now we return properly "placeholder -> full_PID"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Development branch for v3.0.0 #264

Development branch for v3.0.0 #264

Uh oh!

Pfeil commented Jan 24, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 12, 2025 •

edited

Loading

Review skipped

Uh oh!

Pfeil commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Development branch for v3.0.0 #264

Are you sure you want to change the base?

Development branch for v3.0.0 #264

Uh oh!

Conversation

Pfeil commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Pfeil commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pfeil commented Jan 24, 2025 •

edited

Loading

coderabbitai bot commented Jun 12, 2025 •

edited

Loading