Skip to content

Conversation

@Pfeil
Copy link
Member

@Pfeil Pfeil commented Apr 16, 2025

Writing all PIDs to a CSV file was not working since the prefix in the meanwhile always includes a slash at the end, which needs to be removed in this special case.

  • fixed issue
  • improved error messages
  • tested locally

@coveralls
Copy link

Pull Request Test Coverage Report for Build #498

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 72.4%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/kit/datamanager/pit/pidsystem/impl/HandleProtocolAdapter.java 1 33.61%
Totals Coverage Status
Change from base Build #497: 0.08%
Covered Lines: 884
Relevant Lines: 1221

💛 - Coveralls

@Pfeil Pfeil merged commit 8d29770 into master Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants