WIP Add FHNW Solr features: spellcheck, collate, highlighting, and frontend helpers #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reekitconcept
changed the title
reekitconcept
force-pushed
the
fhnw-features
branch
2 times, most recently
from
2a95384 to
5273b71
Compare
…nd helpers NOTE: This changeset extends the backend API to support advanced search features (spellcheck, collate, highlighting), and extends the frontend API to allow projects to implement custom UX on top of kitconcept.solr's capabilities. It also fixes a critical bug where filtering by multiple facet conditions failed to correctly disable voided conditions. When using the built-in default search page, both search and suggest work identically as before. Backend: - Add spellcheck with collate support for "did you mean" suggestions - Add highlighting with alternate field support - Add extra conditions filtering (content types, metadata fields) - Fix facet conditions, portal type, and content fields handling - Fix language handling and encoding issues - Fix local search path prefix matching - Update Solr configuration for spellcheck component - Add upgrade step for highlighting field setup Frontend: - Add getCollationMisspellings helper for "did you mean" feature - Add getSuggestions helper for extracting/sorting suggestions - Add navigation_with_excluded Redux action and reducer - Add SearchWidget customization to use SolrSearchWidget - Updated resultItems/index.js to avoid inline re-export pattern Tests: - Add comprehensive spellcheck/collate tests - Add highlighting endpoint tests - Add extra conditions tests - Add utility function tests
reekitconcept
force-pushed
the
fhnw-features
branch
from
b32ba5a to
dc15232
Compare
The plone.autoinclude loader derives module names from project names
using: `wsdist.project_name.replace("-", "_")`
For kitconcept.solr this produces the wrong import path:
- Project name: kitconcept.solr → PEP 503 normalized: kitconcept-solr
- After replace("-", "_"): kitconcept_solr
- Actual import path: kitconcept.solr (namespace package with dot)
The fix-25 branch (plone/plone.autoinclude#25) addressed this for
z3c.autoinclude.plugin entry points but not for plone.autoinclude.plugin.
Workaround: explicitly set module = "kitconcept.solr" so the loader
uses the specified value instead of deriving it incorrectly.
Refs: plone/plone.autoinclude#25
Refs: plone/Products.CMFPlone#4126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This changeset extends the backend API to support advanced search features (spellcheck, collate, highlighting), and extends the frontend API to allow projects to implement custom UX on top of kitconcept.solr's capabilities.
It also fixes a critical bug where filtering by multiple facet conditions failed to correctly disable voided conditions.
When using the built-in default search page, both search and suggest work identically as before.
Summary
Frontend
getCollationMisspellingshelper for "did you mean" featuregetSuggestionshelper for extracting/sorting suggestionsnavigation_with_excludedRedux action and reducerTests
Test plan