Open
Conversation
Author
|
@danalvrz is this something that could go upstream in here, or should I keep it in our own theme? |
Contributor
|
@polyester We really should improve the color handling here, and fix the conflicts with VLT. Let me take a look at it this week 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change would define five custom text colors, to match up with the five custom colors.
The CSS needs an "!important" in edit mode, to override another !important definition in bgcolor-blocks-layout.scss which says
which would otherwise win, and render the description text always in theme-foreground-color.
Caveat: you have to make sure that the combinations of
highlight-custom-color-x and highlight-custom-text-color-x make up sensible and accessible combinations.