Skip to content

Fall back to original image #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davisagli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fall back to original image #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
311d3d3
Fall back to original image
davisagli Feb 11, 2025
3977c51
Fix CI
davisagli Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ jobs:
wait-on: 'npx wait-on --httpTimeout 20000 http-get://localhost:55001/plone http://localhost:3000'

# Upload Cypress screenshots
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots-acceptance
path: acceptance/cypress/screenshots

# Upload Cypress videos
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-videos-acceptance
Expand Down
1 change: 1 addition & 0 deletions news/29.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use the original image if the preview scale is not available. @davisagli
3 changes: 2 additions & 1 deletion src/components/View.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ const View = (props) => {
<img
src={`${flattenToAppURL(data.image?.[0]?.['@id'])}/${
data.image?.[0]?.image_scales?.image[0]?.scales?.preview
?.download
?.download ||
data.image?.[0]?.image_scales?.image[0]?.download
}}`}
alt={data.image?.[0]?.title}
className="image"
Expand Down
Loading