WIP: Fix how we get the intl provider.#31
Draft
mauritsvanrees wants to merge 2 commits intokitconcept:mainfrom
Draft
WIP: Fix how we get the intl provider.#31mauritsvanrees wants to merge 2 commits intokitconcept:mainfrom
intl provider.#31mauritsvanrees wants to merge 2 commits intokitconcept:mainfrom
Conversation
In production mode only (and possibly depending on Volto and VLT version and which addons you have), I get this error when trying to a add a separator or button block: ``` [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry. ``` So the strange thing is that I can add a quote block and most other blocks but two blocks not. And when I remove the quote block from the addons, all is well. Partially I may have caused this myself last year by this PR: kitconcept#28 That fixed kitconcept#27 for me. But it may have not been the best way. So we try again. But even with the changes I did so far, it does not work for me.
Contributor
Author
|
My fixes are probably more or less good. And I have included the fix from @sneridagh to remove the peer dependency on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production mode only (and possibly depending on Volto and VLT version and which addons you have), I get this error when trying to a add a separator or button block:
So the strange thing is that I can add a quote block and most other blocks but two blocks not. And when I remove the quote block from the addons, all is well.
Partially I may have caused this myself last year by this PR: #28 That fixed #27 for me. But it may have not been the best way.
So we try again. But even with the changes I did so far, it does not work for me. :-(
Does someone know how to properly fix this?
I have Volto 18.29.1 and Volto Light Theme 5.0.2.
This is the same site and the same problem for which @fredvd and me created these issues:
This site with Volto 18.23.0 works, but with later versions not.