[MAINTENANCE] Fix PSR-12 code style

.gitignore

@@ -22,3 +22,4 @@
 _build
 venv
 *.map
+.php-cs-fixer.cache

.php-cs-fixer.dist.php

@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
+ *
+ * This file is part of the Kitodo and TYPO3 projects.
+ *
+ * @license GNU General Public License version 3 or later.
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ */
+
+namespace PhpCsFixer;
+
+$finder = Finder::create()
+    ->in([
+        __DIR__ . '/Classes',
+        __DIR__ . '/Configuration',
+        __DIR__ . '/Tests',
+    ]);
+
+return (new Config())
+    ->setRules([
+        '@PSR12' => true,
+    ])
+    ->setFinder($finder);

Classes/Api/Orcid/Client.php

@@ -31,12 +31,12 @@ class Client
     /**
      * @var string constant for API hostname
      **/
-    const HOSTNAME = 'orcid.org';
+    public const HOSTNAME = 'orcid.org';
 
     /**
      * @var string constant for API version
      **/
-    const VERSION = '3.0';
+    public const VERSION = '3.0';
 
     /**
      * @access protected

Classes/Command/BaseCommand.php

@@ -508,7 +508,7 @@ private function setNewOwner(string $owner): void
     {
         if (empty($this->owner)) {
             // owner is not set but found by metadata --> take it or take default library
-            $owner = $owner ? : 'default';
+            $owner = $owner ?: 'default';
             $this->owner = $this->libraryRepository->findOneBy(['indexName' => $owner]);
             if (empty($this->owner)) {
                 // create library

Classes/Command/DbDocsCommand.php

@@ -33,7 +33,6 @@
  */
 class DbDocsCommand extends Command
 {
-
     protected Generator $generator;
 
     public function __construct(Generator $generator)

Classes/Command/DeleteCommand.php

@@ -33,7 +33,6 @@
  */
 class DeleteCommand extends BaseCommand
 {
-
     /**
      * Configure the command by defining the name, options and arguments
      *

Classes/Command/IndexCommand.php

@@ -34,7 +34,6 @@
  */
 class IndexCommand extends BaseCommand
 {
-
     /**
      * Configure the command by defining the name, options and arguments
      *

Classes/Command/OptimizeCommand.php

@@ -29,7 +29,6 @@
  */
 class OptimizeCommand extends Command
 {
-
     /**
      * Configure the command by defining the name, options and arguments
      *

Classes/Command/SuggestBuildCommand.php

@@ -29,7 +29,6 @@
  */
 class SuggestBuildCommand extends Command
 {
-
     /**
      * Configure the command by defining the name, options and arguments
      *

Classes/Common/AnnotationRequest.php

@@ -37,7 +37,7 @@ public function __construct(string $apiUrl)
      *
      * @return mixed[] Array of annotation data
      */
-    protected function requestAnnotations(string $url) : array
+    protected function requestAnnotations(string $url): array
     {
         $jsonld = Helper::getUrl($url);
 

Classes/Common/DocumentAnnotation.php

@@ -86,7 +86,8 @@ public function getAnnotations(): array
                             if ($this->document->getCurrentDocument() instanceof MetsDocument) {
                                 if (
                                     $meiTargetPages = $this->getMeasurePagesByFileId(
-                                        $annotationTarget->getId(), $annotationTarget->getRangeValue()
+                                        $annotationTarget->getId(),
+                                        $annotationTarget->getRangeValue()
                                     )
                                 ) {
                                     $targetPages[] = [
@@ -96,7 +97,8 @@ public function getAnnotations(): array
                                     ];
                                 } elseif (
                                     $audioTargetPages = $this->getAudioPagesByFileId(
-                                        $annotationTarget->getId(), $annotationTarget->getRangeValue()
+                                        $annotationTarget->getId(),
+                                        $annotationTarget->getRangeValue()
                                     )
                                 ) {
                                     $targetPages[] = [
@@ -132,11 +134,11 @@ public function getAnnotations(): array
                             );
                         }
                     } elseif ($annotationTarget->getObjectId()) {
-                         $objectTargetPages = [];
+                        $objectTargetPages = [];
                         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physInfo) {
-                             $order = $physInfo['order'];
+                            $order = $physInfo['order'];
                             if ($order) {
-                                 $objectTargetPages[] = $order;
+                                $objectTargetPages[] = $order;
                             }
                         }
                         if ($objectTargetPages) {

Classes/Common/FulltextInterface.php

@@ -24,7 +24,6 @@
  */
 interface FulltextInterface
 {
-
     /**
      * Set the page identifier.
      *

Classes/Common/Indexer.php

@@ -46,7 +46,7 @@ class Indexer
     /**
      * Prefix for translation keys.
      */
-    const LANG_PREFIX = 'LLL:EXT:dlf/Resources/Private/Language/locallang_be.xlf:';
+    public const LANG_PREFIX = 'LLL:EXT:dlf/Resources/Private/Language/locallang_be.xlf:';
 
     /**
      * @access protected

Classes/Common/MetsDocument.php

@@ -12,13 +12,13 @@
 
 namespace Kitodo\Dlf\Common;
 
-use \DOMDocument;
-use \DOMElement;
-use \DOMNode;
-use \DOMNodeList;
-use \DOMXPath;
+use DOMDocument;
+use DOMElement;
+use DOMNode;
+use DOMNodeList;
+use DOMXPath;
 use Kitodo\Dlf\Hooks\KitodoProductionHacks;
-use \SimpleXMLElement;
+use SimpleXMLElement;
 use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Database\Query\Restriction\HiddenRestriction;
@@ -1290,7 +1290,7 @@ protected function magicGetMdSec(): array
                 }
             }
 
-            $amdSecXml = $this->mets->xpath('./mets:amdSec');;
+            $amdSecXml = $this->mets->xpath('./mets:amdSec');
             if (!empty($amdSecXml)) {
                 foreach ($amdSecXml as $amdSecTag) {
                     $childIds = [];

Classes/Common/Solr/SearchResult/Highlight.php

@@ -22,7 +22,6 @@
  */
 class Highlight
 {
-
     /**
      * @access private
      * @var string The identifier in form 'w_h_x_y'

Classes/Common/Solr/SearchResult/Page.php

@@ -22,7 +22,6 @@
  */
 class Page
 {
-
     /**
      * @access private
      * @var int The identifier of the page

Classes/Common/Solr/SearchResult/Region.php

@@ -22,7 +22,6 @@
  */
 class Region
 {
-
     /**
      * @access private
      * @var int The identifier of the region

Classes/Common/Solr/SearchResult/ResultDocument.php

@@ -24,7 +24,6 @@
  */
 class ResultDocument
 {
-
     /**
      * @access private
      * @var string|null The identifier

Classes/Common/Solr/Solr.php

@@ -368,7 +368,7 @@ protected function loadSolrConnectionInfo(): void
             }
 
             // Set connection timeout lower than PHP's max_execution_time.
-            $maxExecutionTime = (int) ini_get('max_execution_time') ? : 30;
+            $maxExecutionTime = (int) ini_get('max_execution_time') ?: 30;
             $config['timeout'] = MathUtility::forceIntegerInRange($conf['timeout'] ?? null, 1, $maxExecutionTime, 10);
             $this->config = $config;
         }

Classes/Common/Solr/SolrSearch.php

@@ -605,11 +605,15 @@ public function submit(int $start, int $rows, bool $processResults = true): void
                                 $searchResult['snippet'] = $doc['snippet'];
                                 $searchResult['highlight'] = $doc['highlight'];
                                 $searchResult['highlight_word'] = preg_replace(
-                                    '/^;|;$/', '',  // remove ; at beginning or end
+                                    '/^;|;$/',
+                                    '',  // remove ; at beginning or end
                                     preg_replace(
-                                        '/;+/', ';',  // replace any multiple of ; with a single ;
+                                        '/;+/',
+                                        ';',  // replace any multiple of ; with a single ;
                                         preg_replace(
-                                            '/[{~\d*}{\s+}{^=*\d+.*\d*}{\sAND\s}{\sOR\s}{\sNOT\s}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']
+                                            '/[{~\d*}{\s+}{^=*\d+.*\d*}{\sAND\s}{\sOR\s}{\sNOT\s}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/',
+                                            ';',
+                                            $this->searchParams['query']
                                         )
                                     )
                                 ); // replace search operators and special characters with ;
@@ -845,7 +849,7 @@ protected function searchSolr(array $parameters = [], bool $enableCache = true):
      *
      * @return string
      */
-    private function getCollectionFilterQuery(string $query) : string
+    private function getCollectionFilterQuery(string $query): string
     {
         $collectionsQueryString = '';
         $virtualCollectionsQueryString = '';
@@ -889,7 +893,7 @@ private function getCollectionFilterQuery(string $query) : string
     private function filterCollections(): void
     {
         if (is_array($this->collections)) {
-            array_filter($this->collections, fn($value) => $value !== null);
+            array_filter($this->collections, fn ($value) => $value !== null);
         }
     }
 
@@ -900,7 +904,7 @@ private function filterCollections(): void
      *
      * @return array<string, string>
      */
-    private function getSort() : array
+    private function getSort(): array
     {
         if (!empty($this->searchParams['orderBy'])) {
             return [
@@ -947,7 +951,7 @@ private function getDocument(Document $record, array $highlighting, array $field
 
         foreach ($parameters['listMetadataRecords'] as $indexName => $solrField) {
             if (!empty($record->$solrField)) {
-                    $document['metadata'][$indexName] = $record->$solrField;
+                $document['metadata'][$indexName] = $record->$solrField;
             }
         }
 

Classes/Common/StdOutStream.php

@@ -37,7 +37,7 @@ public function __construct(protected readonly StreamInterface $stream)
 
     /**
      * @access public
-     * 
+     *
      * @return void
      */
     public function emit()

Classes/Configuration/UseGroupsConfiguration.php

@@ -25,7 +25,6 @@
  */
 class UseGroupsConfiguration
 {
-
     /**
      * @access private
      * @var ?UseGroupsConfiguration The instance of singleton.

Classes/Controller/AbstractController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *

Classes/Controller/AudioPlayerController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *

Classes/Controller/Backend/NewTenantController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *

Classes/Controller/BasketController.php

@@ -349,7 +349,7 @@ protected function getDocumentData(string $id, array $data): array|false
 
             $title = $this->document->getTitle();
             if (empty($title)) {
-                $title = LocalizationUtility::translate('basket.noTitle', 'dlf') ? : '';
+                $title = LocalizationUtility::translate('basket.noTitle', 'dlf') ?: '';
             }
 
             // Set page and cutout information

Classes/Controller/CollectionController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *
@@ -138,11 +139,14 @@ public function showAction(Collection $collection): ResponseInterface
         // If a targetPid is given, the results will be shown by ListView on the target page.
         if (!empty($this->settings['targetPid'])) {
             return $this->redirect(
-                'main', 'ListView', null,
+                'main',
+                'ListView',
+                null,
                 [
                     'search' => $search,
                     'page' => $currentPage
-                ], $this->settings['targetPid']
+                ],
+                $this->settings['targetPid']
             );
         }
 

Classes/Controller/Embedded3dViewerController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *
@@ -26,8 +27,7 @@
  */
 class Embedded3dViewerController extends AbstractController
 {
-
-    const MIDDLEWARE_DLF_EMBEDDED_3D_VIEWER_PREFIX = '/?middleware=dlf/embedded3dviewer';
+    public const MIDDLEWARE_DLF_EMBEDDED_3D_VIEWER_PREFIX = '/?middleware=dlf/embedded3dviewer';
 
     /**
      * @access public

Classes/Controller/FeedsController.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
  *
@@ -27,7 +28,6 @@
  */
 class FeedsController extends AbstractController
 {
-
     /**
      * @access protected
      * @var LibraryRepository
@@ -105,7 +105,7 @@ public function mainAction(): ResponseInterface
                 }
                 // Set default title if empty.
                 if (empty($title)) {
-                    $title = LocalizationUtility::translate('noTitle', 'dlf') ? : '';
+                    $title = LocalizationUtility::translate('noTitle', 'dlf') ?: '';
                 }
                 // Append volume information.
                 if (!empty($document->getVolume())) {