Conversation
4839880 to
c2579eb
Compare
oliver-stoehr
left a comment
There was a problem hiding this comment.
Code changes are fine and the script output is displayed as intended.
Is there a reason why error messages are joined in one line, but normal messages are printed on separate lines?
I can't answer this question conclusively as I ran into several problems trying to follow the demo setup. The message itself looks good. I'd say this solution meets our use case if the message text can be marked and copied. |
a7f04c9 to
9f13d45
Compare
Yes, there is a reason. I tried to refactor. But the refactoring included that i handle the exceptions in the TaskService which has access to the UI-logging Helper. But that involved not to throw the Exception in the CommandService. |
This reverts commit 9f13d45.
Text can be marked and copied. |
|
@oliver-stoehr - I now print the error messsages line by line. This can lead to duplications in the UI, because we are not differentiating between CommandExceptions and real IOExceptions. But maybe is it not too bad. |
oliver-stoehr
left a comment
There was a problem hiding this comment.
I think the error messages are more readable this way. 👍

Fixes #6449
This Pull Request tries to apply a minimal fix for the specific problem in #6449, by printing the sucess messages line by line to the task screen on script success.
The user sees only the success or the error messages. Error messages are joined with " | ". The application log tracks all messages combined without specific order.
The printed messages should not take up too much space since the notification area is limited in size and scrollable.
All further ideas as discssed in #6461 are not considered here.