Prevent NPE in calendar when selecting same granularity twice#6523
Merged
solth merged 1 commit intokitodo:mainfrom May 2, 2025
Merged
Prevent NPE in calendar when selecting same granularity twice#6523solth merged 1 commit intokitodo:mainfrom
solth merged 1 commit intokitodo:mainfrom
Conversation
oliver-stoehr
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6437
As @oliver-stoehr suspected, clicking the same
<p:selectOneButton>twice actually deselects the corresponding button/option - as can be seen in this PrimeFaces showcase - which results in no option being selected.Since we do not support selecting no granularity at all in the calendar tool at the moment, simply ignoring the "deselection" events in the correponding bean action should be enough to effectively prevent the reported NPE.