Skip to content

Conversation

@solth
Copy link
Member

@solth solth commented Jan 26, 2026

This pull request adds a new optional paramter subfolders to KitodoScript searchForMedia. By setting this parameter to the value configured the project folder settings are taken into account. This restricts the script to those process subfolders whose contents are set to be linked in the meta.xml file via the project folder settings. Without this parameter (or setting it to any other value than "configured") retains the current behavior where the contents of all process subfolders are linked in the meta.xml file when calling the script searchForMedia.

Thus fixes #6862 for Kitodo 3.8.x (contrary to recent announcements this means there will probably be at least one more bugfix release for version 3.8 of Kitodo)

@solth solth force-pushed the 3-8-search-for-media-in-configured-folders branch from 3247482 to df99db3 Compare January 26, 2026 14:41
Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good but I have the problem that I can not say if this changes are working or not.

We have 3 directories which are all of them are defined to not be linked in the mets file but they are in the internal mets file references as they are used a generator source, preview and media view.

Must I define a additional fourth directory in local system and as a folder with the "no mets link" attribute to see the difference?

And additional question: I though that this linking is only relevant for exporting the process and the meta data / creating additional file groups in the export data - so linking is also relevant for internal meta data file usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants