Change Servlet Mapping and fix SVG exceptions#6968
Merged
solth merged 1 commit intokitodo:mainfrom Apr 13, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
solth
requested review from
henning-gerhardt and
thomaslow
and removed request for
thomaslow
henning-gerhardt
approved these changes
Apr 10, 2026
thomaslow
approved these changes
Apr 10, 2026
Collaborator
thomaslow
left a comment
thomaslow
left a comment
There was a problem hiding this comment.
The proposed change make sense to me and fixes both referenced issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6965
Fixes: #6957
To fix different problems with SVGs in Kitodo in the latest tech stack it is necessary to make the servlet mapping setting more explicit so that SVG files are not handled as JSF pages. This change switches the mapping to
*.xhtml, ensuring that only JSF views are handled by the FacesServlet, while static resources are served directly by the servlet container.