Update omnifaces to version 5.2.3#6995
Closed
henning-gerhardt wants to merge 1 commit intokitodo:mainfrom
Closed
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Collaborator
Author
|
Setting state of pull request to draft as I get 2 exceptions logged on closing the meta data editor at least: First exception: Second exception (immediatly after the first): I have no idea why at least the first exception is thrown nor where I can look for the origin of this exception as the path code is not clear (to me) and I have only limited knowledge about the UI integration. Maybe @solth @thomaslow or @BartChris have an idea? |
Member
|
I am not sure what the reason for the exception is. If this proves to be more difficult to solve I would prefer to schedule it for after the release of Kitodo 4.0, so the later isn't unnecessarily delayed even more. |
Collaborator
Author
|
I tried it with different OmniFaces versions:
|
Collaborator
Author
|
I found a "easy" way to reproduce this exceptions:
|
Member
I can confirm that this exception is now reproducible the way @henning-gerhardt described it above, after #6994 has been merged. |
Collaborator
|
Please keep in mind that dependencies related to JSF are somewhat linked to each other and linked to the Tomcat version. Currently, omnifaces v4 is used because it matches the ecosystem around the Servlet Spec 6.0. Omnifaces 5 is listed to be mainly compatible with Servlet Spec 6.1, which is only supported by Tomcat 11. I wouldn't recommend updating these libraries to their absolute most recent version, but sticking to the current major release that is stated to be compatible to the current Tomcat version. Of course, we still need to investigate the problem that also affects The exception means that the view-state (all @ViewScoped beans for the Metadata Editor) was cleaned up for some reason, which should not happen before the user navigates away from the page with a "view action" or the view-state is dropped from a LRU cache. I am not sure how omnifaces plays into this. Omnifaces shouldn't affect how view-state is cleaned up by JSF. I would have to investigate this in detail. |
Collaborator
Author
|
@thomaslow : You are right. I did not look deep into the requirements for OmniFaces 5.x usage. My thoughts are now:
@solth : What did you think about this 2 thoughts above? |
Member
I agree with both. Concerning this pull request, I would suggest to close it and re-open it once the update to Tomcat 11 is actually being worked on, to avoid adding another old, stale PR lingering in the list for a long time. |
Collaborator
Author
|
@solth: I will do both: closing (and referencing) this pull request and open a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to latest release of omnifaces.
Changes needed as
org.omnifaces.filter.GzipResponseFilterwas deprecated and must be replaces withorg.omnifaces.filter.CompressedResponseFilter*.xhtmlfiles should be replaced (marked as deprecated in5.x) from URI to URN and the different namespaces are merged.