Correct username prompt for logging in to jozu.ml - #936
Conversation
mohammedahmed18
commented
Aug 1, 2025
Signed-off-by: mohammed <mohammed18200118@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the login prompt for the jozu.ml registry by changing the username prompt to "Email:" instead of "Username:" when logging into jozu.ml specifically.
- Updates the username prompt to "Email:" when the registry is "jozu.ml"
- Maintains backward compatibility by keeping "Username:" for all other registries
| if username == "" { | ||
| username, err = util.PromptForInput("Username: ", false) | ||
| usernamePrompt := "Username: " | ||
| if opts.registry == "jozu.ml" { |
There was a problem hiding this comment.
Hard-coding the registry name "jozu.ml" creates a magic string that could be error-prone. Consider defining this as a constant (e.g., const JozuMLRegistry = "jozu.ml") to improve maintainability and reduce the risk of typos.
| if opts.registry == "jozu.ml" { | |
| if opts.registry == jozuMLRegistry { |
|
May be this would work better if it was a url-to-label map that could be utilized for other registries. |
amisevsk
left a comment
There was a problem hiding this comment.
I don't think we should start special-casing different registries to ensure we're showing the correct term here. On jozu.ml, your username is your email -- the credentials you use when logging into the service.
|
I am closing this because this may eventually cause us to special case every known registry. |