Skip to content

Correct username prompt for logging in to jozu.ml - #936

Closed
mohammedahmed18 wants to merge 4 commits into
kitops-ml:mainfrom
mohammedahmed18:correct-username-prompt-for-jozu
Closed

Correct username prompt for logging in to jozu.ml#936
mohammedahmed18 wants to merge 4 commits into
kitops-ml:mainfrom
mohammedahmed18:correct-username-prompt-for-jozu

Conversation

@mohammedahmed18

Copy link
Copy Markdown
Contributor
jozu-login

Signed-off-by: mohammed <mohammed18200118@gmail.com>
@gorkem
gorkem requested a review from Copilot August 2, 2025 10:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the login prompt for the jozu.ml registry by changing the username prompt to "Email:" instead of "Username:" when logging into jozu.ml specifically.

  • Updates the username prompt to "Email:" when the registry is "jozu.ml"
  • Maintains backward compatibility by keeping "Username:" for all other registries

Comment thread pkg/cmd/login/cmd.go Outdated
if username == "" {
username, err = util.PromptForInput("Username: ", false)
usernamePrompt := "Username: "
if opts.registry == "jozu.ml" {

Copilot AI Aug 2, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding the registry name "jozu.ml" creates a magic string that could be error-prone. Consider defining this as a constant (e.g., const JozuMLRegistry = "jozu.ml") to improve maintainability and reduce the risk of typos.

Suggested change
if opts.registry == "jozu.ml" {
if opts.registry == jozuMLRegistry {

Copilot uses AI. Check for mistakes.
@gorkem

gorkem commented Aug 2, 2025

Copy link
Copy Markdown
Member

May be this would work better if it was a url-to-label map that could be utilized for other registries.

Signed-off-by: mohammed <mohammed18200118@gmail.com>
Signed-off-by: mohammed <mohammed18200118@gmail.com>
Signed-off-by: mohammed <mohammed18200118@gmail.com>

@amisevsk amisevsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should start special-casing different registries to ensure we're showing the correct term here. On jozu.ml, your username is your email -- the credentials you use when logging into the service.

@gorkem

gorkem commented Nov 23, 2025

Copy link
Copy Markdown
Member

I am closing this because this may eventually cause us to special case every known registry.

@gorkem gorkem closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants