Open
Conversation
…) + fixed it (_.debounced it)
…r to bookmarkspaginartor.
Contributor
Author
There was a problem hiding this comment.
unified, we call it item_id everywhere (compatible with REST API).
Contributor
|
@dedecej can you review this when you have some time? There is also another pull request here that has been waiting for you for a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So now, the pocket was completely redesigned and rewritten to a large extent.
Most important changes: Now we have tabs-support. It means, we can view not only unread bookmarks, but archived bookmarks and favorite bookmarks as well. Unread bookmarks are cached in chrome.storage, whereas other tabs are loaded as-they-go. This required us to redesign the whole cache and refactor huge chunks of code.
Among "invisible" features, the most notable are: throwing away the coffee script remnants, adding babel and code in ES6, using newer libraries( e.g underscore->lodash). Fixing many, many bugs and edge cases neglected in older version, adding more explanatory comments.