Skip to content

recipes: add new uvloop recipe #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

recipes: add new uvloop recipe #2998

wants to merge 1 commit into from

Conversation

T-Dynamos
Copy link
Contributor

@T-Dynamos T-Dynamos commented Mar 28, 2024 •
edited
Loading

Closes #2997

@T-Dynamos T-Dynamos mentioned this pull request Mar 28, 2024
Closed
@T-Dynamos T-Dynamos marked this pull request as draft March 28, 2024 11:39
@T-Dynamos T-Dynamos marked this pull request as ready for review March 31, 2024 15:12
@T-Dynamos
Copy link
Contributor Author

This PR was ready to be merged.

@misl6
Copy link
Member

misl6 commented May 9, 2024

Do you need to make any changes / rebase as #3007 has been merged?

@T-Dynamos
Copy link
Contributor Author

Surpassed by #3014

@T-Dynamos T-Dynamos closed this May 14, 2024
@vabt-igd
Copy link

vabt-igd commented Sep 3, 2024

@T-Dynamos Was this recipe working on p4a v2024.01.21?
When I use this pr on v2024.01.21, I get the following error message: RuntimeError: the libuv submodule has not been checked out; try running “git submodule init; git submodule update”.
Converting to a CythonRecipe (as uvloop needs cython anyways) takes it a step further, but still results in uvloop/request.pyx:64:21: undeclared name not builtin: convert_error.
Was there more work required to properly build uvloop for arm64-v8a on android?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please add uvloop to recipes!
3 participants
@T-Dynamos @misl6 @vabt-igd